Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.3.0. #392

Merged
merged 29 commits into from
Dec 10, 2021
Merged

Release 2.3.0. #392

merged 29 commits into from
Dec 10, 2021

Conversation

joshuajbouw
Copy link
Contributor

[2.3.0] - 2021-11-10

Added

  • A precompile which exposes NEAR's random number generator was added by [@mfornet] as requested by
    [@birchmd]. (#368 #297)
  • London hard fork support was added by [@birchmd]. (#244)

Changes

  • The gas limit for deposit and ft_on_transfer were changed as they were not attaching enough
    gas, as changed by [@mrLSD]. (#389)

Fixes

  • There was an issue with the original storage not actually being stored. Unfortunately, previous
    transactions can't be updated with this change. This has been fixed by [@birchmd]. (#390)
  • Call arguments were intended to have a value attached to them to make it equivalent to an ETH
    call. This was fixed in a backwards compatible manner by [@andrcmdr], as reported by [@birchmd].
    (#351 #309)
  • A refund now happens in the case of an error on the ExitToNear precompile by [@birchmd].
    (#311)

Removed

  • Betanet support was dropped and will no longer be supported by [@joshuajbouw]. (#388)

birchmd and others added 28 commits November 10, 2021 17:32
* Implementation for deserialized values from bytes to current or legacy Borsh-encoded parameters for passing to the engine `call` function, and to provide backward type compatibility.

* Implementation for deserialized values from bytes to current or legacy Borsh-encoded parameters for passing to the engine `call` function, and to provide backward type compatibility: improved code formatting by `cargo fmt`, addressing notes about bytes order (endianness) in array type conversion to U256 and Wei types, caching bytes returned by `io.read_input()` to prevent double calls for reading register from engine `call()` function during serialization attempts.

* Implementation for deserialized values from bytes to current or legacy Borsh-encoded parameters for passing to the engine `call` function, and to provide backward type compatibility: implemented `deserialize()` method for `CallArgs` to follow SOI principles and made code even more clean on engine top level.

* Implementation for deserialized values from bytes to current or legacy Borsh-encoded parameters for passing to the engine `call` function, and to provide backward type compatibility: improved implementation of `deserialize()` method for `CallArgs` to suppot Borsh bytes parsing for new structures in call args enum (for future extensibility reason), made new tests for `CallArgs::deserialize()` and for old data structure with legacy arguments, add comments, fix existed tests.

* Fix formatting with `cargo fmt`

* Fix existing tests; Formatting with `cargo fmt`

* Fix naming for call args types.
Bumps [@openzeppelin/contracts](https://github.com/OpenZeppelin/openzeppelin-contracts) from 4.3.2 to 4.3.3.
- [Release notes](https://github.com/OpenZeppelin/openzeppelin-contracts/releases)
- [Changelog](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/CHANGELOG.md)
- [Commits](OpenZeppelin/openzeppelin-contracts@v4.3.2...v4.3.3)

---
updated-dependencies:
- dependency-name: "@openzeppelin/contracts"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Drop automagic math ops


Hand write in the boilerplate


Complete rest of precompiles


Fix clippy issues


Fix tests


Fmt


Better implementation


Small fixes


Fix tests


Add missed gas


Feature gate import


Remove unnecessary comment.


Prep for rebase


Remove evm and evm_core from types
Include meta-call feature when running tests

Fix imports, include versioning of imports in prelude.
* NEAR random numbers from solidity contract

Add Precompile that allows calling random numbers from solidity
contracts.

* Use randomSeed as name, and update docstring

* Remove unused constant

* Rename RandomBytes to RandomSeed

* Invoke random_seed outside of the engine

- Make sure random_seed (from NEAR Runtime) is
not called inside the engine.
- Refactor all usage of random_seed to use H256

* Fix CI
Revert chain ID for now


Change note from betanet to localnet
@joshuajbouw joshuajbouw added the C-release Category: New release. label Dec 10, 2021
CHANGES.md Outdated Show resolved Hide resolved
### Fixes

- There was an issue with the original storage not actually being stored. Unfortunately, previous
transactions can't be updated with this change. This has been fixed by [@birchmd]. ([#390])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty poor description that will not be comprehensible to most anybody who reads this changelog. What is "the original storage"? Cool, old transactions can't be updated--what is the actual impact?

@artob artob merged commit c579fc8 into master Dec 10, 2021
@artob artob deleted the release-2.3.0 branch December 10, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-release Category: New release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants