Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(docs): Additional documentation for xcc gas values #590

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

birchmd
Copy link
Member

@birchmd birchmd commented Aug 19, 2022

Adds some documentation of where the various gas constants needed for cross-contract calls came from, as requested by Joshua.

@birchmd birchmd added the C-docs Category: Improvements or additions to documentation label Aug 19, 2022
Copy link
Contributor

@joshuajbouw joshuajbouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@birchmd birchmd merged commit 34c838f into develop Aug 19, 2022
@birchmd birchmd deleted the xcc-documentation branch August 19, 2022 15:35
joshuajbouw added a commit that referenced this pull request Nov 25, 2022
* Chore(docs): Additional documentation for xcc gas values (#590)
* Feat(standalone): Conversion from standalone's TransactionKind to NormalizedEthTransaction (#586)
* Add Backstage metadata (#534)
* Add Backstage metadata
* Fix(aurora-engine-transactions): remove hex feaure from std (#600)
* Feat(tests): benchmark transaction Emufid2pv2UpxrZae4NyowF2N2ZHvYEPq16LsQc7Uoc6 (#599)
* Connector-tests: Add tests for the case where an account other than aurora-engine is used for ETH deposit (#598)
* [Docs] Eth Connector - extended documentation (#601)
* feat: add serde JSON to JSON serializable structs in parameters (#605)
* Pausable precompiles (#588)
* Test(engine): Increase unit test coverage (#614)
* Feat: allow xcc calls to perform any possible NEAR call (#610)
* Test(engine): Increase unit test coverage (#618)
* Refactor: Mark functions that create promises on NEAR as unsafe (#617)
* Fix(xcc): Only update the router contract version in storage if the deploy is successful (#616)
* Fix(CI): broken submodules checkout + Clippy warnings (#621)
* Chore(standalone): Upgrade rocksdb to v0.19. (#615)
* fix: remove sscache from CI (#626)
* Tiny refactoring by clippy suggestions (#625)
* Improvements in log macro (#630)
* Fix (engine): update SputnikVM dependency to avoid stack overflow on deeply nested EVM calls (#628)
* Fix(xcc): Ensure the xcc router attaches enough gas to the execute function (#622)
* Release 2.8.0 notes
* Build: Add reproducible build job. (#633)
* fix: bn 256 regression (#637)
* Update release notes
* Update README to exclude version (#623)
* Chore: Update to SputnikVM version v0.37.1-aurora. Includes some overflow-related fixes. (#638)
* fix: modexp underestimated gas
* chore: bump Cargo to 2.8
* chore: remove version from deployments in README.md

Co-authored-by: Alexey Lapitsky <[email protected]>
Co-authored-by: Joshua J. Bouw <[email protected]>
Co-authored-by: Kirill <[email protected]>
Co-authored-by: Evgeny Ukhanov <[email protected]>
Co-authored-by: Roman Hodulák <[email protected]>
Co-authored-by: Dmitry Strokov <[email protected]>
Co-authored-by: Oleksandr Anyshchenko <[email protected]>
Co-authored-by: Oleksandr Anyshchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs Category: Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants