Fix(xcc): Only update the router contract version in storage if the deploy is successful #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the xcc flow, we store the current version of each deployed sub-account in the Engine's storage. When a router contract is out of date (or the sub-account does not yet exist) then we must deploy the new version and update the entry in storage. The storage update is done as a callback after the deploy. In this PR we add logic to check the deploy was successful before updating the version in storage.
Testing
Existing xcc tests are used for testing (the deploy flow is tested because it occurs when creating a sub-account for the first time).