Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow credential JSON for Spanner options #1941

Closed
lexcao opened this issue Jun 15, 2024 · 0 comments · Fixed by #1942, #1946 or #1948
Closed

Allow credential JSON for Spanner options #1941

lexcao opened this issue Jun 15, 2024 · 0 comments · Fixed by #1942, #1946 or #1948
Labels
kind/proposal Something fundamentally needs to change

Comments

@lexcao
Copy link
Contributor

lexcao commented Jun 15, 2024

Problem Statement

I am using SpiceDB library mode with Spanner for testing.
And I want to pass CredentialsJSON for Spanner.

Solution Brainstorm

Add credentialsJSON for spannerOptions

I will send a PR.
@lexcao lexcao added the kind/proposal Something fundamentally needs to change label Jun 15, 2024
lexcao added a commit to lexcao/spicedb that referenced this issue Jun 15, 2024
@lexcao
Support credential JSON for Spanner
9c1c7a3 
Closes authzed#1941
@lexcao lexcao mentioned this issue Jun 15, 2024
Merged
lexcao added a commit to lexcao/spicedb that referenced this issue Jun 15, 2024
@lexcao
Support credential JSON for Spanner
59c478a 
Closes authzed#1941

Signed-off-by: Lex Cao <[email protected]>
lexcao added a commit to lexcao/spicedb that referenced this issue Jun 17, 2024
@lexcao
Export Spanner credential JSON for datastore
020e0e7 
Closes authzed#1941

Signed-off-by: Lex Cao <[email protected]>
@lexcao lexcao mentioned this issue Jun 17, 2024
Merged
lexcao added a commit to lexcao/spicedb that referenced this issue Jun 18, 2024
@lexcao
Fix empty value on optional credentialsJSON for Spanner
f573a29 
Closes authzed#1941
This is the follow-up PR for authzed#1942, which fix the optional value issue.

Signed-off-by: Lex Cao <[email protected]>
@lexcao lexcao mentioned this issue Jun 18, 2024
Merged
lexcao added a commit to lexcao/spicedb that referenced this issue Jun 18, 2024
@lexcao
Fix empty value on optional credentialsJSON for Spanner
3645316 
Closes authzed#1941
This is the follow-up PR for authzed#1942, which fix the optional value issue.

Signed-off-by: Lex Cao <[email protected]>
lexcao added a commit to lexcao/spicedb that referenced this issue Jun 18, 2024
@lexcao
Fix empty value on optional credentialsJSON for Spanner
3877e9e 
Closes authzed#1941
This is the follow-up PR for authzed#1942, which fix the optional value issue.

Signed-off-by: Lex Cao <[email protected]>
vroldanbet pushed a commit to lexcao/spicedb that referenced this issue Jun 19, 2024
@lexcao @vroldanbet
Fix empty value on optional credentialsJSON for Spanner
d1fc4ee 
Closes authzed#1941
This is the follow-up PR for authzed#1942, which fix the optional value issue.

Signed-off-by: Lex Cao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/proposal Something fundamentally needs to change
Projects
None yet
Milestone
No milestone
1 participant
@lexcao