Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Spanner credential JSON for datastore #1946

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

lexcao
Copy link
Contributor

@lexcao lexcao commented Jun 17, 2024

Closes #1941

This is the followup PR for #1942, I just forgot to export the option to datastore.

@lexcao lexcao requested a review from a team as a code owner June 17, 2024 13:58
@github-actions github-actions bot added the area/CLI Affects the command line label Jun 17, 2024
@lexcao
Copy link
Contributor Author

lexcao commented Jun 17, 2024

Hi @josephschorr
Please help review this PR. Thanks!
Seems the failed CI is irrelevant, how to re-run the CI?

Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024
@josephschorr josephschorr added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024
@josephschorr josephschorr added this pull request to the merge queue Jun 17, 2024
Merged via the queue into authzed:main with commit e78b5d8 Jun 17, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/CLI Affects the command line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow credential JSON for Spanner options
3 participants