Prevent dropping of ca & instructors #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhuangwq
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents (from the front-end) people from dropping ca & instructors.
Motivation and Context
As of current, it is possible to drop the CA & instructors, which is an invalid action. We are currently doing a hotfix to prevent that via the front-end.
How Has This Been Tested?
When Instructor & CA is checked:
When CA is checked:
When nothing is checked:
Unchecks dropped accordingly:
Types of changes
Checklist:
Other issues / help required
If unsure, feel free to submit first and we'll help you along.