Allow instructors to also be CAs

[damianhxy]

Description

Re-allow instructors to be CAs.

Motivation and Context

#2065 prevented instructors from also being CAs. However, this caused problems in parts of the code that set users to be both. Furthermore, it might be desirable to allow instructors to also be CAs since only CAs have sections.

This PR re-allows instructors to be CAs, but improves upon #1420 by disabling the instructor & ca fields when the dropped checkbox is clicked.

How Has This Been Tested?

Edit a user, and check that dropped checkbox disables instructor / ca checkboxes and vice versa.

dropped selected

instructor / ca selected

none selected

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
• My change requires a change to the documentation, which is located at Autolab Docs
• I have updated the documentation accordingly, included in this PR

[coderabbitai]

Walkthrough

Walkthrough

The recent updates focus on refining the user role management within a course platform, specifically targeting the logic surrounding the handling of user roles, such as instructors and course assistants. The primary aim was to streamline the process of enabling or disabling fields based on user roles and to enforce a rule preventing instructors or course assistants from being marked as dropped. This was achieved through a combination of JavaScript and Ruby on Rails model adjustments.

Changes

File Path	Change Summary
.../javascripts/course_user_data_edit.js	Refactored to enhance user role handling logic, introducing disable_fields and instructor_or_ca_not_dropped functions for better field management and mutual exclusion logic.
app/models/course_user_datum.rb	Modified the instructor_or_ca_or_dropped validation to instructor_or_ca_not_dropped, enforcing a rule that disallows marking instructors or course assistants as dropped.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[jlge]

LGTM ✔️