Update NMEA parser to handle bad chars #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it turns out that it is common for the first set of data returned by a gps module to include incorrectly framed characters that break the unicode conversion. - This change ignores exceptions thrown by the unicode decoder and keeps on going until it can read a correctly framed line.
- prior to this change it just kept going, but it should not try to parse a linve with a back checksum.
DocGarbanzo
reviewed
May 20, 2022
donkeycar/parts/gps.py
Outdated
| if (message == "GPRMC") or (message == "GNRMC"): | ||
|
|
||
| if (message == "GPRMC") or (message == "GNRMC"): | ||
| if True or debug: |
There was a problem hiding this comment.
This is always True - why do we need the if. Also we are printing, not logging into the shell, is this intended. I would expect to just have:
logger.debug(line)so if we set global logging to Debug, it will log, otherwise is won't.
There was a problem hiding this comment.
I deleted it; it was left over from finding the problem.
| @@ -57,6 +57,9 @@ def _readline(self) -> str: | |||
| return self.gps.readline().decode() | |||
| except serial.serialutil.SerialException: | |||
| pass | |||
| except UnicodeDecodeError: | |||
There was a problem hiding this comment.
This is the real fix, this looks good.
|
@Ezward - can you please also update the version in |
|
@Ezward - can you please pull from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data returned by a gps module to include incorrectly
framed characters that break the unicode conversion.
unicode decoder and keeps on going until it
can read a correctly framed line.