-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(launch-autoware): add how to launch yabloc or eagleye #411
docs(launch-autoware): add how to launch yabloc or eagleye #411
Conversation
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Hi! This PR is now ready for review. I would like each of you to review the following: 🙏 |
@KYabuuchi Thank you for your PR. LGTM 👍 |
@kminoda I hope you take a look at "YabLoc" and "Localization mode" 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!! Thank you for the document 🙏
Maybe this comment be better to handled first #411 (comment)
docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/yabloc-guide.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/yabloc-guide.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/yabloc-guide.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/yabloc-guide.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/yabloc-guide.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/index.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/index.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/index.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/yabloc-guide.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/yabloc-guide.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
@kminoda I have moved the introduction of YabLoc to the README in autoware.universe. The reviews pointed out have been reflected there. autowarefoundation/autoware.universe#4100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I once dismissed the approval since I got confused with the localization_mode and pose_estimator_mode, but now it's clear that it's not an error (complicated though), so LGTM again!
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
@rsasaki0109 Hi. I made some minor updates to the Eagleye page, so I would appreciate a quick review to ensure everything looks good. 🙇 🙏 |
Sorry. I did not notice the notification. I will check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KYabuuchi
This PR looks very good to me.
There are no issues to point out.
…oundation#411) * add yabloc page but it's empty Signed-off-by: Kento Yabuuchi <[email protected]> * update yabloc-integration-guide Signed-off-by: Kento Yabuuchi <[email protected]> * style(pre-commit): autofix * add what is YabLoc Signed-off-by: Kento Yabuuchi <[email protected]> * moved yabloc and eagleye docs under launch-autoware Signed-off-by: Kento Yabuuchi <[email protected]> * WIP add some descriptions in Japanese Signed-off-by: Kento Yabuuchi <[email protected]> * WIP update Signed-off-by: Kento Yabuuchi <[email protected]> * modified structure Signed-off-by: Kento Yabuuchi <[email protected]> * translate in english Signed-off-by: Kento Yabuuchi <[email protected]> * applied pre-commit Signed-off-by: Kento Yabuuchi <[email protected]> * fix typo Signed-off-by: Kento Yabuuchi <[email protected]> * fix typo again Signed-off-by: Kento Yabuuchi <[email protected]> * reflected reviews Signed-off-by: Kento Yabuuchi <[email protected]> * removed yabloc sub-page Signed-off-by: Kento Yabuuchi <[email protected]> * add comprehensive table Signed-off-by: Kento Yabuuchi <[email protected]> * use markdown rather than html Signed-off-by: Kento Yabuuchi <[email protected]> * i dont know why the table does not appear Signed-off-by: Kento Yabuuchi <[email protected]> * update table Signed-off-by: Kento Yabuuchi <[email protected]> * today's CI is annoying Signed-off-by: Kento Yabuuchi <[email protected]> * split table Signed-off-by: Kento Yabuuchi <[email protected]> --------- Signed-off-by: Kento Yabuuchi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: guiping meng <[email protected]>
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.