Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): use grid_map_utils::PolygonIterator #1018

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jun 1, 2022

Signed-off-by: Maxime CLEMENT [email protected]

Description

Switch to the faster grid_map_utils::PolygonIterator (added in #943) in the occlusion spot module of the behavior_velocity_planner.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem added the type:new-feature New functionalities or additions, feature requests. label Jun 1, 2022
@maxime-clem maxime-clem self-assigned this Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1018 (6bcab45) into main (47eda5f) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1018      +/-   ##
========================================
- Coverage   9.52%   9.49%   -0.03%     
========================================
  Files        953     970      +17     
  Lines      59289   65463    +6174     
  Branches   10793   11705     +912     
========================================
+ Hits        5647    6218     +571     
- Misses     48724   54046    +5322     
- Partials    4918    5199     +281     
Flag Coverage Δ *Carryforward flag
differential 5.10% <0.00%> (?)
total 9.63% <0.00%> (+0.11%) ⬆️ Carriedforward from bf88d08

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/scene_module/occlusion_spot/grid_utils.hpp 0.00% <ø> (ø)
...ity_planner/include/scene_module/run_out/debug.hpp 0.00% <0.00%> (ø)
.../include/scene_module/run_out/dynamic_obstacle.hpp 0.00% <0.00%> (ø)
...y_planner/include/scene_module/run_out/manager.hpp 0.00% <0.00%> (ø)
...lanner/include/scene_module/run_out/path_utils.hpp 0.00% <0.00%> (ø)
...ity_planner/include/scene_module/run_out/utils.hpp 0.00% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.66% <0.00%> (+0.66%) ⬆️
...ner/src/scene_module/occlusion_spot/grid_utils.cpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/debug.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/run_out/dynamic_obstacle.cpp 0.00% <0.00%> (ø)
... and 634 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c0f7e...6bcab45. Read the comment docs.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is faster when comparing with previous polygon iterator using scenario sim LGTM
total time is total processing time for occlusion spot
before
image
after
image
same condition and same scenario test
image

@taikitanaka3 taikitanaka3 merged commit 2bbb23a into autowarefoundation:main Jun 1, 2022
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Jun 7, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@maxime-clem maxime-clem deleted the feat_behavior-velocity-planner_polygon-iterator branch May 29, 2023 02:42
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 29, 2023
…tion

feat(intersection): reduce calculation and improve pass judge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants