-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(behavior_velocity_planner): use faster PolygonIterator #943
perf(behavior_velocity_planner): use faster PolygonIterator #943
Conversation
Codecov Report
@@ Coverage Diff @@
## main #943 +/- ##
=========================================
+ Coverage 9.95% 10.04% +0.08%
=========================================
Files 879 883 +4
Lines 55968 56344 +376
Branches 10577 10794 +217
=========================================
+ Hits 5572 5657 +85
- Misses 45679 45776 +97
- Partials 4717 4911 +194
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
ec33e7b
to
3b749cf
Compare
|
ea41110
to
3d1173d
Compare
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
3d1173d
to
713359c
Compare
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
713359c
to
bcc3c37
Compare
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
@maxime-clem |
@yukkysaito @TakaHoribe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. LGTM
Thank you for the review. |
…foundation#943) * Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: ktro2828 <[email protected]>
* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>
* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>
* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>
* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>
* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>
* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>
* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>
…arefoundation#2571, autowarefoundation#2885, #943) (#337) * feat(elevation_map_loader): reduce memory usage of elevation_map_loader (autowarefoundation#2571) * feat: reduce memory usage of elevation_map_loader Signed-off-by: Shin-kyoto <[email protected]> * chore: remove unnecessary comment Signed-off-by: Shin-kyoto <[email protected]> * fix: modify variables' name Signed-off-by: Shin-kyoto <[email protected]> Signed-off-by: Shin-kyoto <[email protected]> * feat(elevation_map_loader): use polygon iterator to speed up (autowarefoundation#2885) * use grid_map::PolygonIterator instead of grid_map::GridMapIterator Signed-off-by: Shunsuke Miura <[email protected]> * formatting Signed-off-by: Shunsuke Miura <[email protected]> * use use_lane_filter option Signed-off-by: Shunsuke Miura <[email protected]> * delete unused use-lane-filter option Signed-off-by: Shunsuke Miura <[email protected]> * change use_lane_filter to True, clarify the scope Signed-off-by: Shunsuke Miura <[email protected]> * change to use grid_map_utils::PolygonIterator Signed-off-by: Shunsuke Miura <[email protected]> * Add lane margin parameter Signed-off-by: Shunsuke Miura <[email protected]> * use boost geometry buffer to expand lanes Signed-off-by: Shunsuke Miura <[email protected]> * Change use_lane_filter param default to false Signed-off-by: Shunsuke Miura <[email protected]> * update README Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]> * perf(behavior_velocity_planner): add faster PolygonIterator (#943) * Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]> * suppress error --------- Signed-off-by: Shin-kyoto <[email protected]> Signed-off-by: Shunsuke Miura <[email protected]> Signed-off-by: Maxime CLEMENT <[email protected]> Co-authored-by: Shintaro Tomie <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]> Co-authored-by: Maxime CLEMENT <[email protected]>
feat(lane_change): cherry-pick LC PRs
Signed-off-by: Maxime CLEMENT [email protected]
Description
This PR adds a faster
PolygonIterator
for thegrid_map
library.Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.