perf(behavior_velocity_planner): use faster PolygonIterator #943

maxime-clem · 2022-05-20T09:37:26Z

Signed-off-by: Maxime CLEMENT [email protected]

Description

This PR adds a faster PolygonIterator for the grid_map library.

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov · 2022-05-20T09:48:55Z

Codecov Report

Merging #943 (3c0cd88) into main (4e30bf5) will increase coverage by 0.08%.
The diff coverage is 22.60%.

@@            Coverage Diff            @@
##            main     #943      +/-   ##
=========================================
+ Coverage   9.95%   10.04%   +0.08%     
=========================================
  Files        879      883       +4     
  Lines      55968    56344     +376     
  Branches   10577    10794     +217     
=========================================
+ Hits        5572     5657      +85     
- Misses     45679    45776      +97     
- Partials    4717     4911     +194

Flag	Coverage Δ		*Carryforward flag
differential	`21.54% <21.54%> (?)`
total	`9.95% <ø> (ø)`		Carriedforward from a942475

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
common/grid_map_utils/test/benchmark.cpp	`0.00% <0.00%> (ø)`
...mmon/grid_map_utils/test/test_polygon_iterator.cpp	`10.98% <10.98%> (ø)`
common/grid_map_utils/src/polygon_iterator.cpp	`58.87% <58.87%> (ø)`
..._utils/include/grid_map_utils/polygon_iterator.hpp	`75.00% <75.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e30bf5...3c0cd88. Read the comment docs.

common/grid_map_utils/src/polygon_iterator.cpp

taikitanaka3 · 2022-05-24T06:47:47Z

please make PR to grid map core too if this is merged and test result become nicer.
please add brief description to this package

Signed-off-by: Maxime CLEMENT <[email protected]>

taikitanaka3 · 2022-05-30T10:10:18Z

@maxime-clem
I close and reopen this pr for updating ci

taikitanaka3 · 2022-05-30T10:24:32Z

@yukkysaito @TakaHoribe
This is just PR for adding new package.
There is a test for comparing polygon iterator of grid map package and @maxime-clem 's grid map utils.
I think merge isReady.

yukkysaito

Awesome. LGTM

maxime-clem · 2022-05-30T11:31:40Z

Thank you for the review.
Friday I tested a new feature making use of this faster PolygonIterator and did not encounter any issue.
I will merge this.

…foundation#943) * Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: ktro2828 <[email protected]>

* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>

…arefoundation#2571, autowarefoundation#2885, #943) (#337) * feat(elevation_map_loader): reduce memory usage of elevation_map_loader (autowarefoundation#2571) * feat: reduce memory usage of elevation_map_loader Signed-off-by: Shin-kyoto <[email protected]> * chore: remove unnecessary comment Signed-off-by: Shin-kyoto <[email protected]> * fix: modify variables' name Signed-off-by: Shin-kyoto <[email protected]> Signed-off-by: Shin-kyoto <[email protected]> * feat(elevation_map_loader): use polygon iterator to speed up (autowarefoundation#2885) * use grid_map::PolygonIterator instead of grid_map::GridMapIterator Signed-off-by: Shunsuke Miura <[email protected]> * formatting Signed-off-by: Shunsuke Miura <[email protected]> * use use_lane_filter option Signed-off-by: Shunsuke Miura <[email protected]> * delete unused use-lane-filter option Signed-off-by: Shunsuke Miura <[email protected]> * change use_lane_filter to True, clarify the scope Signed-off-by: Shunsuke Miura <[email protected]> * change to use grid_map_utils::PolygonIterator Signed-off-by: Shunsuke Miura <[email protected]> * Add lane margin parameter Signed-off-by: Shunsuke Miura <[email protected]> * use boost geometry buffer to expand lanes Signed-off-by: Shunsuke Miura <[email protected]> * Change use_lane_filter param default to false Signed-off-by: Shunsuke Miura <[email protected]> * update README Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]> * perf(behavior_velocity_planner): add faster PolygonIterator (#943) * Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]> * suppress error --------- Signed-off-by: Shin-kyoto <[email protected]> Signed-off-by: Shunsuke Miura <[email protected]> Signed-off-by: Maxime CLEMENT <[email protected]> Co-authored-by: Shintaro Tomie <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]> Co-authored-by: Maxime CLEMENT <[email protected]>

feat(lane_change): cherry-pick LC PRs

maxime-clem added the type:new-feature New functionalities or additions, feature requests. label May 20, 2022

maxime-clem requested a review from taikitanaka3 May 20, 2022 09:37

maxime-clem self-assigned this May 20, 2022

maxime-clem force-pushed the perf-polygon_iterator branch from ec33e7b to 3b749cf Compare May 20, 2022 09:59

taikitanaka3 requested a review from yukkysaito May 24, 2022 06:40

taikitanaka3 reviewed May 24, 2022

View reviewed changes

common/grid_map_utils/src/polygon_iterator.cpp Outdated Show resolved Hide resolved

taikitanaka3 reviewed May 24, 2022

View reviewed changes

common/grid_map_utils/src/polygon_iterator.cpp Outdated Show resolved Hide resolved

maxime-clem force-pushed the perf-polygon_iterator branch 2 times, most recently from ea41110 to 3d1173d Compare May 25, 2022 12:26

maxime-clem added 9 commits May 25, 2022 22:12

Add grid_map_utils pkg with faster implementation of PolygonIterator

216f101

Signed-off-by: Maxime CLEMENT <[email protected]>

Factorize code of PolygonIterator (ongoing)

64ea717

Signed-off-by: Maxime CLEMENT <[email protected]>

Add program to visualize difference with grid_map::PolygonIterator

354d4ad

Signed-off-by: Maxime CLEMENT <[email protected]>

Cleanup code and make behavior closer to grid_map::PolygonIterator

0d67dc0

Signed-off-by: Maxime CLEMENT <[email protected]>

Fix bug: some pairs of y intersection outside the map were not removed

15c4102

Signed-off-by: Maxime CLEMENT <[email protected]>

Replace debug visualization exe with benchmark+visualization exe

7d0756f

Signed-off-by: Maxime CLEMENT <[email protected]>

Fix bug when calculating min_vertex_x + code cleanup

7fdf7ab

Signed-off-by: Maxime CLEMENT <[email protected]>

Calculate Indexes during iteration (faster than during construction)

0c2e26c

Signed-off-by: Maxime CLEMENT <[email protected]>

Change list to vector for better performances

c89e28a

Signed-off-by: Maxime CLEMENT <[email protected]>

maxime-clem force-pushed the perf-polygon_iterator branch from 3d1173d to 713359c Compare May 25, 2022 13:24

maxime-clem added 2 commits May 25, 2022 22:31

Add README and runtime comparison figure

e28c2f6

Signed-off-by: Maxime CLEMENT <[email protected]>

Remove polygon drawing and cleanup benchmark

bcc3c37

Signed-off-by: Maxime CLEMENT <[email protected]>

maxime-clem force-pushed the perf-polygon_iterator branch from 713359c to bcc3c37 Compare May 25, 2022 13:31

maxime-clem marked this pull request as ready for review May 25, 2022 14:57

maxime-clem added 3 commits May 26, 2022 08:55

Add 2 failing tests + improve benchmark

a942475

Signed-off-by: Maxime CLEMENT <[email protected]>

Update edge case test (diff with grid_map) and update README:Assumptions

99f3071

Signed-off-by: Maxime CLEMENT <[email protected]>

Fix self-crossing test

3c0cd88

Signed-off-by: Maxime CLEMENT <[email protected]>

taikitanaka3 closed this May 30, 2022

taikitanaka3 reopened this May 30, 2022

yukkysaito approved these changes May 30, 2022

View reviewed changes

maxime-clem merged commit 90f5f56 into autowarefoundation:main May 30, 2022

maxime-clem deleted the perf-polygon_iterator branch May 30, 2022 11:33

tier4-autoware-public-bot bot mentioned this pull request May 31, 2022

chore: sync upstream tier4/autoware.universe#52

Merged

maxime-clem mentioned this pull request Jun 1, 2022

feat(behavior_velocity_planner): use grid_map_utils::PolygonIterator #1018

Merged

4 tasks

maxime-clem referenced this pull request in tier4/autoware.universe Aug 3, 2022

perf(behavior_velocity_planner): add faster PolygonIterator (#943)

66a97da

* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>

maxime-clem referenced this pull request in tier4/autoware.universe Aug 11, 2022

perf(behavior_velocity_planner): add faster PolygonIterator (#943)

fa9ae50

* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>

boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022

perf(behavior_velocity_planner): add faster PolygonIterator (tier4#943)

81af9ea

* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>

boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022

perf(behavior_velocity_planner): add faster PolygonIterator (tier4#943)

21d35ff

* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>

boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022

perf(behavior_velocity_planner): add faster PolygonIterator (tier4#943)

f7b4ecd

* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>

boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022

perf(behavior_velocity_planner): add faster PolygonIterator (tier4#943)

cd95d70

* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>

h-ohta referenced this pull request in tier4/autoware.universe Mar 24, 2023

perf(behavior_velocity_planner): add faster PolygonIterator (#943)

0f67f5e

* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <[email protected]>

h-ohta mentioned this pull request Mar 24, 2023

feat(elevation_map_loader): large size pointcloud map (backport #2571, #2885, #943) tier4/autoware.universe#337

Merged

4 tasks

YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Oct 19, 2023

Merge pull request autowarefoundation#943 from tier4/lc-update-20231013

02b5f1a

feat(lane_change): cherry-pick LC PRs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(behavior_velocity_planner): use faster PolygonIterator #943

perf(behavior_velocity_planner): use faster PolygonIterator #943

maxime-clem commented May 20, 2022 •

edited

Loading

codecov bot commented May 20, 2022 •

edited

Loading

taikitanaka3 commented May 24, 2022

taikitanaka3 commented May 30, 2022

taikitanaka3 commented May 30, 2022

yukkysaito left a comment

maxime-clem commented May 30, 2022

perf(behavior_velocity_planner): use faster PolygonIterator #943

perf(behavior_velocity_planner): use faster PolygonIterator #943

Conversation

maxime-clem commented May 20, 2022 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented May 20, 2022 • edited Loading

Codecov Report

taikitanaka3 commented May 24, 2022

taikitanaka3 commented May 30, 2022

taikitanaka3 commented May 30, 2022

yukkysaito left a comment

Choose a reason for hiding this comment

maxime-clem commented May 30, 2022

maxime-clem commented May 20, 2022 •

edited

Loading

codecov bot commented May 20, 2022 •

edited

Loading