Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_utils): add new orientation calculation #1126

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jun 17, 2022

Signed-off-by: yutaka [email protected]

Description

Add a new option to calculate the interpolated pose orientation

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1126 (2b69592) into main (ae75c9b) will increase coverage by 0.06%.
The diff coverage is 56.52%.

@@           Coverage Diff            @@
##            main   #1126      +/-   ##
========================================
+ Coverage   9.04%   9.10%   +0.06%     
========================================
  Files       1031    1029       -2     
  Lines      69974   70045      +71     
  Branches   14597   14643      +46     
========================================
+ Hits        6327    6378      +51     
+ Misses     58227   58212      -15     
- Partials    5420    5455      +35     
Flag Coverage Δ *Carryforward flag
differential 9.37% <53.57%> (?)
total 9.03% <57.69%> (+<0.01%) ⬆️ Carriedforward from 71c7425

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...autoware_utils/test/src/geometry/test_geometry.cpp 40.27% <49.36%> (+3.08%) ⬆️
...include/tier4_autoware_utils/geometry/geometry.hpp 92.68% <100.00%> (+0.68%) ⬆️
...ontrol_rviz_plugin/src/tools/manual_controller.cpp 0.00% <0.00%> (ø)
localization/twist2accel/src/twist2accel.cpp
localization/twist2accel/src/twist2accel_node.cpp
...planning_evaluator/src/planning_evaluator_node.cpp 38.14% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae75c9b...2b69592. Read the comment docs.

geometry_msgs::msg::Pose src_pose;
src_pose.position = createPoint(0.0, 0.0, 0.0);
src_pose.orientation = createQuaternionFromRPY(deg2rad(0), deg2rad(0), deg2rad(0));
{{geometry_msgs::msg::Pose src_pose;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unusual shape, but CI has passed...hmm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He asked me about that in another PR. Removing one pair of {} can solve this format collapse.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@TakaHoribe TakaHoribe self-requested a review June 20, 2022 04:55
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note, this function is still a new one, not used anywhere.

@purewater0901 purewater0901 merged commit d811eff into autowarefoundation:main Jun 20, 2022
@purewater0901 purewater0901 deleted the feat/add-new-orientatio-calculation branch June 20, 2022 05:21
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat(tier4_autoware_utils): add new orientation calculation

Signed-off-by: yutaka <[email protected]>

* fix format
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(tier4_autoware_utils): add new orientation calculation

Signed-off-by: yutaka <[email protected]>

* fix format
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(tier4_autoware_utils): add new orientation calculation

Signed-off-by: yutaka <[email protected]>

* fix format
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat(tier4_autoware_utils): add new orientation calculation

Signed-off-by: yutaka <[email protected]>

* fix format
yn-mrse referenced this pull request in tier4/autoware.universe Jun 21, 2023
* feat(tier4_autoware_utils): add new orientation calculation

Signed-off-by: yutaka <[email protected]>

* fix format
yn-mrse referenced this pull request in tier4/autoware.universe Jun 21, 2023
* feat(tier4_autoware_utils): add new orientation calculation

Signed-off-by: yutaka <[email protected]>

* fix format
yn-mrse referenced this pull request in tier4/autoware.universe Jun 21, 2023
#1100, #1126) (#592)

* feat(tier4_autoware_utils): add pose interpolation function (#1097)

Signed-off-by: yutaka <[email protected]>

* feat(tier4_autoware_utils): add new orientation calculation (#1126)

* feat(tier4_autoware_utils): add new orientation calculation

Signed-off-by: yutaka <[email protected]>

* fix format

* feat(tier4_autoware_utils): add point interpolation function (#1100)

---------

Signed-off-by: yutaka <[email protected]>
Co-authored-by: Yutaka Shimizu <[email protected]>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Feb 7, 2024
…on/refactor_pointcloud_container

feat(perception): refactor pointcloud container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants