-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: read float param #1357
fix: read float param #1357
Conversation
Signed-off-by: suchang <[email protected]>
Signed-off-by: suchang <[email protected]>
@storrrrrrrrm |
Codecov Report
@@ Coverage Diff @@
## main #1357 +/- ##
=====================================
Coverage 9.04% 9.04%
=====================================
Files 1031 1031
Lines 69973 69973
Branches 14597 14597
=====================================
Hits 6328 6328
Misses 58226 58226
Partials 5419 5419
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
it is a fix,z_offset is defined as a float value, but if you config z_offset=-2.0 in launch.xml,when you
it crash |
@storrrrrrrrm |
Signed-off-by: suchang <[email protected]>
-2 is better for default value when you set target_frame='base_link' in launch.xml, it means the height from target_frame to a fake toplidar frame which i think the apollo model trained from. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* read float param Signed-off-by: suchang <[email protected]> * remove cout Signed-off-by: suchang <[email protected]> * change default z_offset Signed-off-by: suchang <[email protected]> Co-authored-by: suchang <[email protected]>
* read float param Signed-off-by: suchang <[email protected]> * remove cout Signed-off-by: suchang <[email protected]> * change default z_offset Signed-off-by: suchang <[email protected]> Co-authored-by: suchang <[email protected]>
* read float param Signed-off-by: suchang <[email protected]> * remove cout Signed-off-by: suchang <[email protected]> * change default z_offset Signed-off-by: suchang <[email protected]> Co-authored-by: suchang <[email protected]>
* read float param Signed-off-by: suchang <[email protected]> * remove cout Signed-off-by: suchang <[email protected]> * change default z_offset Signed-off-by: suchang <[email protected]> Co-authored-by: suchang <[email protected]>
* read float param Signed-off-by: suchang <[email protected]> * remove cout Signed-off-by: suchang <[email protected]> * change default z_offset Signed-off-by: suchang <[email protected]> Co-authored-by: suchang <[email protected]>
* read float param Signed-off-by: suchang <[email protected]> * remove cout Signed-off-by: suchang <[email protected]> * change default z_offset Signed-off-by: suchang <[email protected]> Co-authored-by: suchang <[email protected]>
Signed-off-by: suchang [email protected]
Description
before:
after:
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.