fix: read float param

[storrrrrrrrm]

Signed-off-by: suchang [email protected]

Description

before:

after:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[taikitanaka3]

@storrrrrrrrm
is this a fix PR or you want to restrict value to float in this PR?
I think before cases include node_->declare_parameter("z_offset", 2); this change so it should die.
but I think if this change is not included z_offset is read int and cast to float, right?

[codecov]

Codecov Report

Merging #1357 (bb81c61) into main (2a4a37e) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main   #1357   +/-   ##
=====================================
  Coverage   9.04%   9.04%           
=====================================
  Files       1031    1031           
  Lines      69973   69973           
  Branches   14597   14597           
=====================================
  Hits        6328    6328           
  Misses     58226   58226           
  Partials    5419    5419           

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	9.02% <0.00%> (ø)		Carriedforward from 939459c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...idar_apollo_instance_segmentation/src/detector.cpp	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a4a37e...bb81c61. Read the comment docs.

[storrrrrrrrm]

it is a fix,z_offset is defined as a float value, but if you config z_offset=-2.0 in launch.xml,when you

ros2 launch lidar_apollo_instance_segmentation lidar_apollo_instance_segmentation.launch.xml

it crash

[taikitanaka3]

@storrrrrrrrm

The sign of z offset is reversed , Do you know better default value? It should be positive or negative both.

[storrrrrrrrm]

@storrrrrrrrm The sign of z offset is reversed , Do you know better default value? It should be positive or negative both.

-2 is better for default value when you set target_frame='base_link' in launch.xml, it means the height from target_frame to a fake toplidar frame which i think the apollo model trained from.

[taikitanaka3]

LGTM

[yukkysaito]

LGTM