Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scan_ground_filter): fix segmentation fault #1503

Merged
merged 5 commits into from
Aug 3, 2022

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Aug 2, 2022

Description

Fix segmentation fault due to access violation in out_radial_ordered_points[radial_div]

Test procedure

Run rosbag replay simulation with sample-bag and other rosbags to verify that the scan ground filter is not terminated.
Tested with rosbag, which was causing the segmentation fault, and confirmed that there was no problem.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
@miursh miursh changed the title Fix/segfault scan ground feat(scan_ground_filter): fix segmentation fault Aug 2, 2022
@miursh miursh marked this pull request as ready for review August 2, 2022 14:45
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1503 (9f89ea3) into main (3f90850) will decrease coverage by 0.66%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             main   #1503      +/-   ##
=========================================
- Coverage   10.30%   9.63%   -0.67%     
=========================================
  Files        1128    1096      -32     
  Lines       72707   77185    +4478     
  Branches    17929   17705     -224     
=========================================
- Hits         7489    7440      -49     
- Misses      57449   62504    +5055     
+ Partials     7769    7241     -528     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.63% <0.00%> (-0.67%) ⬇️ Carriedforward from 539345a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nd_segmentation/src/scan_ground_filter_nodelet.cpp 0.00% <0.00%> (ø)
...planner/include/scene_module/stop_line/manager.hpp 0.00% <ø> (ø)
...ocity_planner/src/scene_module/stop_line/debug.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/stop_line/manager.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/stop_line/scene.cpp 0.00% <0.00%> (ø)
...wer/include/trajectory_follower/mpc_trajectory.hpp 0.00% <0.00%> (-50.00%) ⬇️
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
...motion_utils/src/vehicle/vehicle_state_checker.cpp 60.00% <0.00%> (-10.00%) ⬇️
.../src/vehicle/test_vehicle_state_checker_helper.hpp 70.58% <0.00%> (-9.42%) ⬇️
planning/behavior_path_planner/test/input.cpp 60.00% <0.00%> (-7.86%) ⬇️
... and 788 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7dfa19...9f89ea3. Read the comment docs.

@miursh miursh changed the title feat(scan_ground_filter): fix segmentation fault fix(scan_ground_filter): fix segmentation fault Aug 2, 2022
@TomohitoAndo
Copy link
Contributor

I confirmed this node is not terminated and works well with rosbag replay simulation.

@miursh miursh enabled auto-merge (squash) August 3, 2022 04:22
@miursh miursh merged commit 01a83cb into autowarefoundation:main Aug 3, 2022
TomohitoAndo referenced this pull request in tier4/autoware.universe Aug 3, 2022
* feat(scan_ground_filter): fix segfault

Signed-off-by: Shunsuke Miura <[email protected]>

* change using sentence

Signed-off-by: Shunsuke Miura <[email protected]>

* fix

Signed-off-by: Shunsuke Miura <[email protected]>

* remove unused code

Signed-off-by: Shunsuke Miura <[email protected]>
TomohitoAndo referenced this pull request in tier4/autoware.universe Aug 3, 2022
fix(scan_ground_filter): fix segmentation fault (#1503)
@miursh miursh deleted the fix/segfault_scan_ground branch August 3, 2022 10:16
yukke42 referenced this pull request in tier4/autoware.universe Aug 9, 2022
* feat(scan_ground_filter): fix segfault

Signed-off-by: Shunsuke Miura <[email protected]>

* change using sentence

Signed-off-by: Shunsuke Miura <[email protected]>

* fix

Signed-off-by: Shunsuke Miura <[email protected]>

* remove unused code

Signed-off-by: Shunsuke Miura <[email protected]>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Aug 10, 2022
)

* feat(scan_ground_filter): fix segfault

Signed-off-by: Shunsuke Miura <[email protected]>

* change using sentence

Signed-off-by: Shunsuke Miura <[email protected]>

* fix

Signed-off-by: Shunsuke Miura <[email protected]>

* remove unused code

Signed-off-by: Shunsuke Miura <[email protected]>
TomohitoAndo referenced this pull request in tier4/autoware.universe Aug 10, 2022
* feat(scan_ground_filter): fix segfault

Signed-off-by: Shunsuke Miura <[email protected]>

* change using sentence

Signed-off-by: Shunsuke Miura <[email protected]>

* fix

Signed-off-by: Shunsuke Miura <[email protected]>

* remove unused code

Signed-off-by: Shunsuke Miura <[email protected]>

Co-authored-by: Shunsuke Miura <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat(scan_ground_filter): fix segfault

Signed-off-by: Shunsuke Miura <[email protected]>

* change using sentence

Signed-off-by: Shunsuke Miura <[email protected]>

* fix

Signed-off-by: Shunsuke Miura <[email protected]>

* remove unused code

Signed-off-by: Shunsuke Miura <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(scan_ground_filter): fix segfault

Signed-off-by: Shunsuke Miura <[email protected]>

* change using sentence

Signed-off-by: Shunsuke Miura <[email protected]>

* fix

Signed-off-by: Shunsuke Miura <[email protected]>

* remove unused code

Signed-off-by: Shunsuke Miura <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(scan_ground_filter): fix segfault

Signed-off-by: Shunsuke Miura <[email protected]>

* change using sentence

Signed-off-by: Shunsuke Miura <[email protected]>

* fix

Signed-off-by: Shunsuke Miura <[email protected]>

* remove unused code

Signed-off-by: Shunsuke Miura <[email protected]>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
)

* feat(scan_ground_filter): fix segfault

Signed-off-by: Shunsuke Miura <[email protected]>

* change using sentence

Signed-off-by: Shunsuke Miura <[email protected]>

* fix

Signed-off-by: Shunsuke Miura <[email protected]>

* remove unused code

Signed-off-by: Shunsuke Miura <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat(scan_ground_filter): fix segfault

Signed-off-by: Shunsuke Miura <[email protected]>

* change using sentence

Signed-off-by: Shunsuke Miura <[email protected]>

* fix

Signed-off-by: Shunsuke Miura <[email protected]>

* remove unused code

Signed-off-by: Shunsuke Miura <[email protected]>
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Sep 6, 2024
…cherry-pick-bpp

fix(bpp): use common steering factor interface for same scene modules (autowarefoundation#8675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants