Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elevation_map_loader): remove and create map bagfile if it cannot be loaded #1772

Merged

Conversation

Shin-kyoto
Copy link
Contributor

@Shin-kyoto Shin-kyoto commented Sep 2, 2022

Signed-off-by: Shin-kyoto [email protected]

PR Type

  • Bug Fix

Description

  • When bag file of elevation map is broken, elevation_map_loader node cannot load it and dies.
  • So if elevation_map_loader node cannot load broken bag file, removing broken bag file and create elevation map.

Review Procedure

Follow the steps below to ensure that the elevation map is generated even if there is broken bag file in /install/elevation_map_loader/share/elevation_map_loader/data/elevation_maps.

  1. Create elevation map.
  2. Check if there is .db3 file in /install/elevation_map_loader/share/elevation_map_loader/data/elevation_maps/<MAP_HASH>/. <MAP_HASH> depends on pointcloud map you used to create elevation_map. For example, /install/elevation_map_loader/share/elevation_map_loader/data/elevation_maps/2b0fe3948d486f048177b826fbba046d468956e51b25e9916feef02b0aeffeee/2b0fe3948d486f048177b826fbba046d468956e51b25e9916feef02b0aeffeee_0.db3 is that bag file.
  3. Remove this file and create empty file with the same name as the removed bag file. For example,
rm -rf /install/elevation_map_loader/share/elevation_map_loader/data/elevation_maps/2b0fe3948d486f048177b826fbba046d468956e51b25e9916feef02b0aeffeee/2b0fe3948d486f048177b826fbba046d468956e51b25e9916feef02b0aeffeee_0.db3
touch /install/elevation_map_loader/share/elevation_map_loader/data/elevation_maps/2b0fe3948d486f048177b826fbba046d468956e51b25e9916feef02b0aeffeee/2b0fe3948d486f048177b826fbba046d468956e51b25e9916feef02b0aeffeee_0.db3
  1. Check if the broken bag file is removed and the elevation map is generated again.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Shin-kyoto Shin-kyoto added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 2, 2022
@Shin-kyoto Shin-kyoto self-assigned this Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1772 (e48748a) into main (81ce496) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1772      +/-   ##
==========================================
- Coverage   10.40%   10.38%   -0.02%     
==========================================
  Files        1218     1218              
  Lines       87306    87403      +97     
  Branches    20227    20227              
==========================================
  Hits         9081     9081              
- Misses      68771    68868      +97     
  Partials     9454     9454              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.38% <0.00%> (ø) Carriedforward from fcd7fd6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ation_map_loader/src/elevation_map_loader_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Shin-kyoto Shin-kyoto marked this pull request as ready for review September 5, 2022 09:03
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shin-kyoto Shin-kyoto merged commit 90fb5e1 into autowarefoundation:main Sep 6, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
… be loaded (autowarefoundation#1772)

* fix(elevation_map_loader): remove and create map bagfile if it cannot be loaded

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): add dependencies

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): use snake case for variable

Signed-off-by: Shin-kyoto <[email protected]>

Signed-off-by: Shin-kyoto <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
… be loaded (autowarefoundation#1772)

* fix(elevation_map_loader): remove and create map bagfile if it cannot be loaded

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): add dependencies

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): use snake case for variable

Signed-off-by: Shin-kyoto <[email protected]>

Signed-off-by: Shin-kyoto <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
… be loaded (autowarefoundation#1772)

* fix(elevation_map_loader): remove and create map bagfile if it cannot be loaded

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): add dependencies

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): use snake case for variable

Signed-off-by: Shin-kyoto <[email protected]>

Signed-off-by: Shin-kyoto <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
… be loaded (autowarefoundation#1772)

* fix(elevation_map_loader): remove and create map bagfile if it cannot be loaded

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): add dependencies

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): use snake case for variable

Signed-off-by: Shin-kyoto <[email protected]>

Signed-off-by: Shin-kyoto <[email protected]>
yn-mrse pushed a commit to tier4/autoware.universe that referenced this pull request Dec 22, 2022
… be loaded (autowarefoundation#1772)

* fix(elevation_map_loader): remove and create map bagfile if it cannot be loaded

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): add dependencies

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): use snake case for variable

Signed-off-by: Shin-kyoto <[email protected]>

Signed-off-by: Shin-kyoto <[email protected]>
yn-mrse added a commit to tier4/autoware.universe that referenced this pull request Dec 23, 2022
… be loaded (backport autowarefoundation#1772) (#218)

fix(elevation_map_loader): remove and create map bagfile if it cannot be loaded (autowarefoundation#1772)

* fix(elevation_map_loader): remove and create map bagfile if it cannot be loaded

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): add dependencies

Signed-off-by: Shin-kyoto <[email protected]>

* fix(elevation_map_loader): use snake case for variable

Signed-off-by: Shin-kyoto <[email protected]>

Signed-off-by: Shin-kyoto <[email protected]>

Signed-off-by: Shin-kyoto <[email protected]>
Co-authored-by: Shintaro Tomie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants