Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vehicle_cmd_gate): move private headers #1799

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Sep 7, 2022

Signed-off-by: Takagi, Isamu [email protected]

Description

Move private headers from include to src.
autowarefoundation/autoware#2824 (comment)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi self-assigned this Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1799 (330e243) into main (505f975) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
+ Coverage   10.41%   10.44%   +0.02%     
==========================================
  Files        1218     1220       +2     
  Lines       87464    87500      +36     
  Branches    20479    20492      +13     
==========================================
+ Hits         9107     9136      +29     
- Misses      68878    68885       +7     
  Partials     9479     9479              
Flag Coverage Δ *Carryforward flag
differential 17.64% <ø> (?)
total 10.39% <ø> (ø) Carriedforward from 505f975

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.cpp 75.30% <ø> (+4.39%) ⬆️
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.hpp 87.50% <ø> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.25% <ø> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <ø> (ø)
...icle_cmd_gate/test/src/test_vehicle_cmd_filter.cpp 60.86% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) September 16, 2022 08:27
@isamu-takagi isamu-takagi merged commit d181522 into autowarefoundation:main Sep 20, 2022
@isamu-takagi isamu-takagi deleted the refactor/private-headers/vehicle-cmd-gate branch September 20, 2022 08:03
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants