Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator #1814

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 8, 2022

Signed-off-by: Takamasa Horibe [email protected]

Add super useful test scripts for the accel brake map calibration. It generates an ActuationCmd with a constant accel/brake value interactively given through CLI by a user.

Related links

Tests performed

Check if the scripts work following the description in readme.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <[email protected]>
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1814 (e44f4cf) into main (1ddaa90) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
- Coverage   10.39%   10.39%   -0.01%     
==========================================
  Files        1218     1218              
  Lines       87577    87578       +1     
  Branches    20511    20510       -1     
==========================================
- Hits         9104     9100       -4     
- Misses      69012    69139     +127     
+ Partials     9461     9339     -122     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.37% <ø> (-0.01%) ⬇️ Carriedforward from 0fb1fab

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 64.15% <0.00%> (-9.44%) ⬇️
common/osqp_interface/src/osqp_interface.cpp 34.35% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
planning/rtc_interface/src/rtc_interface.cpp 0.00% <0.00%> (ø)
control/trajectory_follower/src/mpc_utils.cpp 58.25% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.42% <0.00%> (ø)
common/motion_utils/src/marker/marker_helper.cpp 0.00% <0.00%> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 3.32% <0.00%> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.25% <0.00%> (ø)
... and 83 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkuri
Copy link
Contributor

mkuri commented Sep 9, 2022

@TakaHoribe
The class and node names in the actuation_cmd_publisher.py are still brake_publisher, could you please correct them to actuation_cmd_publisher?

Signed-off-by: Takamasa Horibe <[email protected]>
@TakaHoribe
Copy link
Contributor Author

@mkuri Thank you! Done!

$ ros2 node list
/actuation_cmd_publisher
/vehicle_accel_tester
/vehicle_brake_tester

Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe enabled auto-merge (squash) September 9, 2022 11:37
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit ce3ecfb into autowarefoundation:main Sep 15, 2022
@TakaHoribe TakaHoribe deleted the feat/add-test-utils-for-accel-map-calibrator branch September 15, 2022 06:32
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…generator (autowarefoundation#1814)

* feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator

Signed-off-by: Takamasa Horibe <[email protected]>

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

* fix names

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…generator (autowarefoundation#1814)

* feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator

Signed-off-by: Takamasa Horibe <[email protected]>

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

* fix names

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…generator (autowarefoundation#1814)

* feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator

Signed-off-by: Takamasa Horibe <[email protected]>

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

* fix names

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…generator (autowarefoundation#1814)

* feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator

Signed-off-by: Takamasa Horibe <[email protected]>

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

* fix names

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants