-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator #1814
feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator #1814
Conversation
…generator Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1814 +/- ##
==========================================
- Coverage 10.39% 10.39% -0.01%
==========================================
Files 1218 1218
Lines 87577 87578 +1
Branches 20511 20510 -1
==========================================
- Hits 9104 9100 -4
- Misses 69012 69139 +127
+ Partials 9461 9339 -122
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@TakaHoribe |
Signed-off-by: Takamasa Horibe <[email protected]>
@mkuri Thank you! Done!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…generator (autowarefoundation#1814) * feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator Signed-off-by: Takamasa Horibe <[email protected]> * update readme Signed-off-by: Takamasa Horibe <[email protected]> * fix names Signed-off-by: Takamasa Horibe <[email protected]> Signed-off-by: Takamasa Horibe <[email protected]>
…generator (autowarefoundation#1814) * feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator Signed-off-by: Takamasa Horibe <[email protected]> * update readme Signed-off-by: Takamasa Horibe <[email protected]> * fix names Signed-off-by: Takamasa Horibe <[email protected]> Signed-off-by: Takamasa Horibe <[email protected]>
…generator (autowarefoundation#1814) * feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator Signed-off-by: Takamasa Horibe <[email protected]> * update readme Signed-off-by: Takamasa Horibe <[email protected]> * fix names Signed-off-by: Takamasa Horibe <[email protected]> Signed-off-by: Takamasa Horibe <[email protected]>
…generator (autowarefoundation#1814) * feat(accel_brake_map_calibrator): add test scripts for acc/brake cmd generator Signed-off-by: Takamasa Horibe <[email protected]> * update readme Signed-off-by: Takamasa Horibe <[email protected]> * fix names Signed-off-by: Takamasa Horibe <[email protected]> Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe [email protected]
Add super useful test scripts for the accel brake map calibration. It generates an ActuationCmd with a constant accel/brake value interactively given through CLI by a user.
Related links
Tests performed
Check if the scripts work following the description in readme.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.