-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): pull over deceleration #1860
fix(behavior_path_planner): pull over deceleration #1860
Conversation
Signed-off-by: kosuke55 <[email protected]>
Codecov ReportBase: 10.44% // Head: 10.42% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
- Coverage 10.44% 10.42% -0.03%
==========================================
Files 1224 1224
Lines 87784 87962 +178
Branches 20463 20584 +121
==========================================
Hits 9171 9171
- Misses 69109 69275 +166
- Partials 9504 9516 +12
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n#1860) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…n#1860) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…n#1860) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…n#1860) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…n#1860) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…n#1860) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…n#1860) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…n#1860) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
Description
refined_goal_pose_
is used for deceleration, but it is not set.refined_goal_pose_
only once when onEntry to reduce calculation cost.Related links
caused by #1777
Tests performed
psim
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.