Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): pull over deceleration #1860

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 14, 2022

Description

  • fix pull_over deceleration before goal search area.
    • refined_goal_pose_ is used for deceleration, but it is not set.
  • calculate refined_goal_pose_ only once when onEntry to reduce calculation cost.

Related links

caused by #1777

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 10.44% // Head: 10.42% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (262a9fb) compared to base (cf4ae72).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1860      +/-   ##
==========================================
- Coverage   10.44%   10.42%   -0.03%     
==========================================
  Files        1224     1224              
  Lines       87784    87962     +178     
  Branches    20463    20584     +121     
==========================================
  Hits         9171     9171              
- Misses      69109    69275     +166     
- Partials     9504     9516      +12     
Flag Coverage Δ *Carryforward flag
differential 1.27% <0.00%> (?)
total 10.43% <0.00%> (ø) Carriedforward from cf4ae72

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit c496a82 into autowarefoundation:main Sep 14, 2022
@kosuke55 kosuke55 deleted the fix/pull_over_deceleration branch September 14, 2022 06:43
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants