Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointcloud_preprocessor): separate targets for base class #1982

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Sep 28, 2022

Description

closes #1009

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@wep21
Copy link
Contributor Author

wep21 commented Sep 28, 2022

@lchojnack Could you try this PR for #1009? I can also reproduce the error with following commands.

ros2 run rclcpp_components component_container_mt
ros2 component load /ComponentManager compare_map_segmentation compare_map_segmentation::CompareElevationMapFilterComponent
ros2 component load /ComponentManager pointcloud_preprocessor pointcloud_preprocessor::VoxelGridOutlierFilterComponent

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 10.40% // Head: 10.40% // No change to project coverage 👍

Coverage data is based on head (38ebd01) compared to base (342a959).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1982   +/-   ##
=======================================
  Coverage   10.40%   10.40%           
=======================================
  Files        1159     1159           
  Lines       82172    82172           
  Branches    19290    19290           
=======================================
  Hits         8554     8554           
  Misses      64348    64348           
  Partials     9270     9270           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.39% <0.00%> (ø) Carriedforward from 342a959

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ssing/include/signal_processing/lowpass_filter.hpp 100.00% <ø> (ø)
...nal_processing/test/src/lowpass_filter_1d_test.cpp 35.71% <0.00%> (ø)
...signal_processing/test/src/lowpass_filter_test.cpp 25.71% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lhakim85
Copy link

lhakim85 commented Oct 7, 2022

@lchojnack Could you try this PR for #1009? I can also reproduce the error with following commands.

I try this PR but get this error
image

Any idea @wep21

@lchojnack
Copy link
Contributor

@lchojnack Could you try this PR for #1009? I can also reproduce the error with following commands.

@wep21 I've tested the PR and it's working. I don't see the issue anymore.

@mitsudome-r
Copy link
Member

@lhakim85 Could you provide more details about your environment? (compiler, arm or amd64, etc)
Our build check on CI is passing, and we will be merging if we can't reproduce your issue on our machines.

@lhakim85
Copy link

@mitsudome-r here the detail
Setup A
Ubuntu 20.04.5
gcc 9.4.0
Intel i7-8700
GPU RTX 3060
Source installation
Amd64

Setup B
Ubuntu 20.04.5
gcc 9.4.0
Intel i9-10900k
GPU RTX 2070
Source installation
Amd64

Both setup fail to compile with same error

Copy link
Contributor

@lchojnack lchojnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me.

Ubuntu20.04
11th Gen Intel® Core™ i7-11800H
GPU RTX 2520
gcc 9.4.0

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit c430b52 into main Oct 13, 2022
@shmpwk shmpwk deleted the fix/compare_map_segmentation_load branch October 13, 2022 02:38
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 28, 2022
…refoundation#1982)

Signed-off-by: Daisuke Nishimatsu <[email protected]>

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Oct 28, 2022
* fix(pointcloud_preprocessor): separate targets for base class (autowarefoundation#1982)

Signed-off-by: Daisuke Nishimatsu <[email protected]>

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>

* fix(pointcloud_preprocessor): add missed target dependency (autowarefoundation#2101)

Signed-off-by: Kaan Colak <[email protected]>

Signed-off-by: Kaan Colak <[email protected]>

* fix: remove un-existed file from cmake

Signed-off-by: tomoya.kimura <[email protected]>

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
Signed-off-by: Kaan Colak <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Kaan Çolak <[email protected]>
scepter914 pushed a commit to scepter914/autoware.universe that referenced this pull request Nov 1, 2022
…refoundation#1982)

Signed-off-by: Daisuke Nishimatsu <[email protected]>

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: scepter914 <[email protected]>
tzhong518 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 9, 2022
* fix(pointcloud_preprocessor): separate targets for base class (autowarefoundation#1982)

Signed-off-by: Daisuke Nishimatsu <[email protected]>

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>

* fix(pointcloud_preprocessor): add missed target dependency (autowarefoundation#2101)

Signed-off-by: Kaan Colak <[email protected]>

Signed-off-by: Kaan Colak <[email protected]>

* fix: remove un-existed file from cmake

Signed-off-by: tomoya.kimura <[email protected]>

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
Signed-off-by: Kaan Colak <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Kaan Çolak <[email protected]>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 2, 2023
* fix(pointcloud_preprocessor): separate targets for base class (autowarefoundation#1982)

Signed-off-by: Daisuke Nishimatsu <[email protected]>

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>

* fix(pointcloud_preprocessor): add missed target dependency (autowarefoundation#2101)

Signed-off-by: Kaan Colak <[email protected]>

Signed-off-by: Kaan Colak <[email protected]>

* fix: remove un-existed file from cmake

Signed-off-by: tomoya.kimura <[email protected]>

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
Signed-off-by: Kaan Colak <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Kaan Çolak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes the sensing module doesn't publish concatenated pointcloud
6 participants