-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pointcloud_preprocessor): add missed target dependency #2101
fix(pointcloud_preprocessor): add missed target dependency #2101
Conversation
Signed-off-by: Kaan Colak <[email protected]>
Hello, @yukkysaito , @amc-nu. Could you review this PR? |
Codecov ReportBase: 10.37% // Head: 10.37% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
=======================================
Coverage 10.37% 10.37%
=======================================
Files 1175 1175
Lines 84044 84044
Branches 19591 19591
=======================================
Hits 8717 8717
Misses 65791 65791
Partials 9536 9536
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kaancolak I'm sorry, this is my mistake. Thank you for your fix. |
…oundation#2101) Signed-off-by: Kaan Colak <[email protected]> Signed-off-by: Kaan Colak <[email protected]>
* fix(pointcloud_preprocessor): separate targets for base class (autowarefoundation#1982) Signed-off-by: Daisuke Nishimatsu <[email protected]> Signed-off-by: Daisuke Nishimatsu <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> * fix(pointcloud_preprocessor): add missed target dependency (autowarefoundation#2101) Signed-off-by: Kaan Colak <[email protected]> Signed-off-by: Kaan Colak <[email protected]> * fix: remove un-existed file from cmake Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: Daisuke Nishimatsu <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: Kaan Colak <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Kaan Çolak <[email protected]>
* fix(pointcloud_preprocessor): separate targets for base class (autowarefoundation#1982) Signed-off-by: Daisuke Nishimatsu <[email protected]> Signed-off-by: Daisuke Nishimatsu <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> * fix(pointcloud_preprocessor): add missed target dependency (autowarefoundation#2101) Signed-off-by: Kaan Colak <[email protected]> Signed-off-by: Kaan Colak <[email protected]> * fix: remove un-existed file from cmake Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: Daisuke Nishimatsu <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: Kaan Colak <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Kaan Çolak <[email protected]>
* fix(pointcloud_preprocessor): separate targets for base class (autowarefoundation#1982) Signed-off-by: Daisuke Nishimatsu <[email protected]> Signed-off-by: Daisuke Nishimatsu <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> * fix(pointcloud_preprocessor): add missed target dependency (autowarefoundation#2101) Signed-off-by: Kaan Colak <[email protected]> Signed-off-by: Kaan Colak <[email protected]> * fix: remove un-existed file from cmake Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: Daisuke Nishimatsu <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: Kaan Colak <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Kaan Çolak <[email protected]>
Signed-off-by: Kaan Colak [email protected]
Description
pointcloud_preprocessor crashes when
logging_simulator.launch.xml
is launched with theuse_pointcloud_container:=false
param while a ros2 bag plays.But;
The package doesn't crash.
I added pcl_ros to ament_target_dependencies and it looks like everything works without any problem.
Relevant PR: fix(pointcloud_preprocessor): separate targets for base class
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.