fix(pointcloud_preprocessor): add missed target dependency

[kaancolak]

Signed-off-by: Kaan Colak [email protected]

Description

pointcloud_preprocessor crashes when logging_simulator.launch.xml is launched with the use_pointcloud_container:=false param while a ros2 bag plays.

ros2 launch autoware_launch logging_simulator.launch.xml map_path:=/home/kaan/projects/sample-map-rosbag vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit
ros2 bag play ~/sample-rosbag/sample.db3 -r 0.2 -s sqlite3

But;

ros2 launch autoware_launch logging_simulator.launch.xml map_path:=/home/kaan/projects/sample-map-rosbag vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit use_pointcloud_container:=true
ros2 bag play ~/sample-rosbag/sample.db3 -r 0.2 -s sqlite3

The package doesn't crash.

I added pcl_ros to ament_target_dependencies and it looks like everything works without any problem.

Relevant PR: fix(pointcloud_preprocessor): separate targets for base class

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[kaancolak]

Hello, @yukkysaito , @amc-nu. Could you review this PR?

[codecov]

Codecov Report

Base: 10.37% // Head: 10.37% // No change to project coverage 👍

Coverage data is based on head (49efada) compared to base (272f8a2).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2101   +/-   ##
=======================================
  Coverage   10.37%   10.37%           
=======================================
  Files        1175     1175           
  Lines       84044    84044           
  Branches    19591    19591           
=======================================
  Hits         8717     8717           
  Misses      65791    65791           
  Partials     9536     9536           

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <ø> (?)
total	10.35% <ø> (ø)		Carriedforward from 8fc7be4

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[yukkysaito]

LGTM

[wep21]

@kaancolak I'm sorry, this is my mistake. Thank you for your fix.