-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rtc_manager_panel): add rtc all approval #2009
feat(rtc_manager_panel): add rtc all approval #2009
Conversation
Signed-off-by: taikitanaka3 <[email protected]>
Codecov ReportBase: 10.34% // Head: 10.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2009 +/- ##
==========================================
- Coverage 10.34% 10.33% -0.01%
==========================================
Files 1162 1162
Lines 82744 82821 +77
Branches 19280 19280
==========================================
Hits 8559 8559
- Misses 64925 65002 +77
Partials 9260 9260
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: taikitanaka3 <[email protected]>
Signed-off-by: tanaka3 <[email protected]>
@rej55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I add some suggestions.
Could you check them?
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Signed-off-by: tanaka3 <[email protected]>
…add_rtc_manager_approval_all
Signed-off-by: tanaka3 <[email protected]>
Signed-off-by: tanaka3 <[email protected]>
@rej55 |
I tried this tool. I think execute button for following modules should be separated from other modules.
|
@rej55
yes I implemented it but it sometimes doesn't work as expected, maybe because of latency of button signal and fast update of rtc status. if it works fine I will add. |
Longitudinal command is okay but lateral modules should not be placed all execute command. |
This suggestion will be handled in other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(rtc_manager_panel): add rtc all approval Signed-off-by: taikitanaka3 <[email protected]> * chore: cosmetic change Signed-off-by: taikitanaka3 <[email protected]> * fix: static cast Signed-off-by: tanaka3 <[email protected]> * chore: update text Co-authored-by: Fumiya Watanabe <[email protected]> * chore: update text Co-authored-by: Fumiya Watanabe <[email protected]> * doc: update documents Signed-off-by: tanaka3 <[email protected]> * doc: update Signed-off-by: tanaka3 <[email protected]> * doc: small update Signed-off-by: tanaka3 <[email protected]> Signed-off-by: taikitanaka3 <[email protected]> Signed-off-by: tanaka3 <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]>
Signed-off-by: taikitanaka3 [email protected]
Description
2022-10-04-13-43-41.mp4
Related links
resolve #2009
'Tier4 INTERNAL LINK'
Tests performed
not yet
Notes for reviewers
this can easily tested by psim
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.