feat(rtc_manager_panel): add rtc all approval

[taikitanaka3]

Signed-off-by: taikitanaka3 [email protected]

Description

• add rtc exe mode and wait mode button

2022-10-04-13-43-41.mp4

Related links

resolve #2009

'Tier4 INTERNAL LINK'

Tests performed

not yet

Notes for reviewers

this can easily tested by psim

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Base: 10.34% // Head: 10.33% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (dbfaecd) compared to base (7648dec).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
- Coverage   10.34%   10.33%   -0.01%     
==========================================
  Files        1162     1162              
  Lines       82744    82821      +77     
  Branches    19280    19280              
==========================================
  Hits         8559     8559              
- Misses      64925    65002      +77     
  Partials     9260     9260              

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	10.32% <0.00%> (ø)		Carriedforward from 08c4852

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp	0.00% <0.00%> (ø)
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.hpp	0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[taikitanaka3]

@rej55
Can you review this PR?

[rej55]

Thank you!
I add some suggestions.
Could you check them?

[github-actions]

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-2009/
Modified URLs:

• https://autowarefoundation.github.io/autoware.universe/pr-2009/common/rtc_manager_rviz_plugin/

[taikitanaka3]

The document is going to look like this.

[taikitanaka3]

@rej55
I updated documents with Execute and Wait button. It will be more appropriate expression

[rej55]

I tried this tool.
It is okay for modules included in behavior_velocity_planner.

I think execute button for following modules should be separated from other modules.
Furthermore, it would be better to have separate buttons for individual ids.

• Lane change
• Avoidance
• Pull over
• Pull out

[taikitanaka3]

@rej55
How about this layout?

All Cooperate Command	Execute	Wait
Lateral Cooperate Command	Execute	Wait
Longitudinal Cooperate Command	Execute	Wait

it would be better to have separate buttons for individual ids

yes I implemented it but it sometimes doesn't work as expected, maybe because of latency of button signal and fast update of rtc status. if it works fine I will add.

[rej55]

Longitudinal command is okay but lateral modules should not be placed all execute command.
This is because most lateral modules cannot be canceled once executed.

[rej55]

I tried this tool. It is okay for modules included in behavior_velocity_planner.

I think execute button for following modules should be separated from other modules. Furthermore, it would be better to have separate buttons for individual ids.

• Lane change
• Avoidance
• Pull over
• Pull out

This suggestion will be handled in other PR.

[rej55]

LGTM