Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): add an explanation #2034

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Oct 7, 2022

Signed-off-by: yutaka [email protected]

Description

Add more explanations to the terminal stop parameter

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link
Contributor

kosuke55 commented Oct 7, 2022

Signed-off-by: yutaka <[email protected]>
@purewater0901
Copy link
Contributor Author

@kosuke55 I just updated the parameter description on the readme. Let me know if you think we should have more details about this new parameter.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaks! looks good!

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 10.41% // Head: 10.41% // No change to project coverage 👍

Coverage data is based on head (49d9ea1) compared to base (365c725).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2034   +/-   ##
=======================================
  Coverage   10.41%   10.41%           
=======================================
  Files        1169     1169           
  Lines       83523    83523           
  Branches    19552    19552           
=======================================
  Hits         8695     8695           
  Misses      65452    65452           
  Partials     9376     9376           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.39% <0.00%> (ø) Carriedforward from 365c725

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 enabled auto-merge (squash) October 7, 2022 08:18
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 5162d75 into autowarefoundation:main Oct 7, 2022
@purewater0901 purewater0901 deleted the feat/add-explanation-to-terminal-stop-dist branch October 7, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants