-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_cruise_planner): add an explanation #2034
feat(obstacle_cruise_planner): add an explanation #2034
Conversation
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
@kosuke55 I just updated the parameter description on the readme. Let me know if you think we should have more details about this new parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thaks! looks good!
Codecov ReportBase: 10.41% // Head: 10.41% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2034 +/- ##
=======================================
Coverage 10.41% 10.41%
=======================================
Files 1169 1169
Lines 83523 83523
Branches 19552 19552
=======================================
Hits 8695 8695
Misses 65452 65452
Partials 9376 9376
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: yutaka [email protected]
Description
Add more explanations to the terminal stop parameter
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.