refactor(trajectory_follower/trajectory_follower_nodes): remove autoware_auto_common dependency

[takayuki5168]

Signed-off-by: Takayuki Murooka [email protected]

Description

related to #2229

remove autoware_auto_common dependency, which is added in autoware.auto, from trajectory_follower/trajectory_follower_nodes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Base: 11.14% // Head: 11.64% // Increases project coverage by +0.50% 🎉

Coverage data is based on head (b451cab) compared to base (8f8ec9d).
Patch coverage: 59.65% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2228      +/-   ##
==========================================
+ Coverage   11.14%   11.64%   +0.50%     
==========================================
  Files        1203     1203              
  Lines       86268    87070     +802     
  Branches    20829    21390     +561     
==========================================
+ Hits         9615    10140     +525     
- Misses      66490    66563      +73     
- Partials    10163    10367     +204     

Flag	Coverage Δ		*Carryforward flag
differential	40.32% <54.58%> (?)
total	11.12% <51.40%> (ø)		Carriedforward from 8f8ec9d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...ctory_follower/include/trajectory_follower/mpc.hpp	42.85% <ø> (-3.81%)	⬇️
...wer/include/trajectory_follower/mpc_trajectory.hpp	60.00% <ø> (+10.00%)	⬆️
...rajectory_follower/pid_longitudinal_controller.hpp	50.00% <ø> (+21.42%)	⬆️
...e/trajectory_follower/qp_solver/qp_solver_osqp.hpp	0.00% <ø> (ø)
...ory_follower/qp_solver/qp_solver_unconstr_fast.hpp	100.00% <ø> (ø)
...llower/include/trajectory_follower/smooth_stop.hpp	0.00% <ø> (ø)
...r/vehicle_model/vehicle_model_bicycle_dynamics.hpp	100.00% <ø> (ø)
...vehicle_model/vehicle_model_bicycle_kinematics.hpp	100.00% <ø> (ø)
...odel/vehicle_model_bicycle_kinematics_no_delay.hpp	100.00% <ø> (ø)
control/trajectory_follower/src/mpc_trajectory.cpp	76.47% <ø> (ø)
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[takayuki5168]

I confirmed locally that planning simulator works well

[TakaHoribe]

It worked well.

Note: the motion_common was temporally ported to support .auto pkgs when the autoware.universe started. Since now the utility functions are managed by other packages (autoware_utils, motion_utils, etc), the old motion_common dependency is removed.

Using the defined types are still under discussion in the autoware.core, but at least it is not necessary in the universe. The control node uses the default premitive types to follow the other packages.

[takayuki5168]

I confirmed that planning simulator works well locally