Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_velocity_limiter): use motion_utils instead of motion_common #2273

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 12, 2022

Signed-off-by: Takayuki Murooka [email protected]

Description

use motion_utils package instead of motion_common
#2229

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 marked this pull request as ready for review November 12, 2022 02:45
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 11.10% // Head: 11.10% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5e50dfb) compared to base (a2bcd7c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2273      +/-   ##
==========================================
- Coverage   11.10%   11.10%   -0.01%     
==========================================
  Files        1208     1208              
  Lines       86573    86597      +24     
  Branches    20829    20851      +22     
==========================================
+ Hits         9612     9613       +1     
- Misses      66805    66827      +22     
- Partials    10156    10157       +1     
Flag Coverage Δ *Carryforward flag
differential 18.76% <0.00%> (?)
total 11.07% <ø> (ø) Carriedforward from a2bcd7c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_limiter/src/obstacle_velocity_limiter_node.cpp 1.11% <0.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Nov 12, 2022

@maxime-clem Could you review this PR as well.
There is no behavior change

@takayuki5168 takayuki5168 merged commit b6f68a5 into autowarefoundation:main Nov 14, 2022
@takayuki5168 takayuki5168 deleted the refactor/remove-motion-common-from-planning branch November 14, 2022 10:40
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…on_common (autowarefoundation#2273)

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…on_common (autowarefoundation#2273)

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: kminoda <[email protected]>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…on_common (autowarefoundation#2273)

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants