Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): add guard for failed optimized trajectory #2398

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 29, 2022

Description

commit to apply tier4#194 to main

fix for https://tier4.atlassian.net/browse/T4PB-23420 (TIER IV internal link)

When optimization failed, trajectory sometimes diverged.
In order to send this kind of trajectory to the latter module, I added a guard seeing how much deviation the trajectory has against the reference path.
If the deviation is too large, sends a previously planned path to the latter module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 29, 2022
@takayuki5168 takayuki5168 marked this pull request as ready for review November 29, 2022 06:13
@takayuki5168 takayuki5168 requested a review from a team as a code owner November 29, 2022 06:13
@takayuki5168 takayuki5168 changed the title Fix/failed trajectory guard main fix(obstacle_avoidance_planner): add guard for failed optimized trajectory Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 10.50% // Head: 10.46% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (412de4c) compared to base (a7270a8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2398      +/-   ##
==========================================
- Coverage   10.50%   10.46%   -0.04%     
==========================================
  Files        1260     1260              
  Lines       91667    92016     +349     
  Branches    21123    21123              
==========================================
  Hits         9630     9630              
- Misses      71829    72178     +349     
  Partials    10208    10208              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.48% <0.00%> (ø) Carriedforward from a7270a8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 force-pushed the fix/failed-trajectory-guard-main branch from 5287cba to fb0cae0 Compare December 1, 2022 08:11
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 enabled auto-merge (squash) December 1, 2022 08:17
@takayuki5168 takayuki5168 merged commit 7aa9314 into autowarefoundation:main Dec 1, 2022
@takayuki5168 takayuki5168 deleted the fix/failed-trajectory-guard-main branch December 1, 2022 08:53
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…ctory (autowarefoundation#2398)

* fix(obstacle_avoidance_planner): add guard for failed optimized trajectory

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* add error message

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…ctory (autowarefoundation#2398)

* fix(obstacle_avoidance_planner): add guard for failed optimized trajectory

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* add error message

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: kminoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants