-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): change planner data update method #2510
feat(behavior_path_planner): change planner data update method #2510
Conversation
Signed-off-by: yutaka <[email protected]>
Codecov ReportBase: 11.28% // Head: 10.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
- Coverage 11.28% 10.43% -0.86%
==========================================
Files 1166 1266 +100
Lines 81863 88552 +6689
Branches 20947 21597 +650
==========================================
+ Hits 9242 9243 +1
- Misses 62758 69381 +6623
- Partials 9863 9928 +65
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: yutaka <[email protected]>
…ware.universe into feat/add-planner-data-updater
Signed-off-by: yutaka <[email protected]>
Although it should not be a problem in practice, there is still a concurrency issue.
When 2 threads are working in parallel, the following situation may occur:
-> Consequence:
The pattern is exactly the same with the |
@VRichardJP Thank you. Then how about creating a new
|
Yes, I think you cannot get rid of a mutex. |
@VRichardJP Thank you so much! I'll add the mutex in my code. |
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
@VRichardJP I just added the mutex, could you please check my modification? |
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
…arefoundation#2510) * feat(behavior_path_planner): change planner data update method Signed-off-by: yutaka <[email protected]> * remove unnecessary code Signed-off-by: yutaka <[email protected]> * update Signed-off-by: yutaka <[email protected]> * add mutex Signed-off-by: yutaka <[email protected]> * update Signed-off-by: yutaka <[email protected]> * fix comment Signed-off-by: yutaka <[email protected]> * add mutex Signed-off-by: yutaka <[email protected]> Signed-off-by: yutaka <[email protected]> Signed-off-by: kminoda <[email protected]>
Signed-off-by: yutaka [email protected]
Description
Currently,
planner_data_
is copied incorrectly, and it might cause some serious issues. In this PR, I fixed the problem.Related Issues
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.