-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(diagnostic_converter): add converter to use planning_evaluator's output for scenario's condition #2514
feat(diagnostic_converter): add converter to use planning_evaluator's output for scenario's condition #2514
Conversation
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
I am unable to build the new package due to a missing message:
In the CI this also causes an issue:
|
@maxime-clem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works well.
@mitsudome-r |
<group if="$(var launch_planning_evaluator)"> | ||
<include file="$(find-pkg-share planning_evaluator)/launch/planning_evaluator.launch.xml"/> | ||
</group> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TakaHoribe I remember you saying that planning_evaluator nodes are expected to launch regardless of simulation or real vehicle driving (e.g., to publish diagnostics for MRM triggering). Is it correct?
If that's true, then I think this should be included from planning.launch, not simulator.launch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kyoichi-sugahara @mitsudome-r Thank you for the mention. Right, the planning evaluator should be launched in both sim and real, and thus be called from the planning.launch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitsudome-r @TakaHoribe
I have modified code so that the planning_evaluator
node is always laucnhed from planning.launch and confirmed its behavior with this new PR.
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… output for scenario's condition (autowarefoundation#2514) * add original diagnostic_convertor Signed-off-by: kyoichi-sugahara <[email protected]> * add test Signed-off-by: kyoichi-sugahara <[email protected]> * fix typo Signed-off-by: kyoichi-sugahara <[email protected]> * delete file Signed-off-by: kyoichi-sugahara <[email protected]> * change include Signed-off-by: kyoichi-sugahara <[email protected]> * temp Signed-off-by: kyoichi-sugahara <[email protected]> * delete comments Signed-off-by: kyoichi-sugahara <[email protected]> * made launch for converter Signed-off-by: kyoichi-sugahara <[email protected]> * ci(pre-commit): autofix * ci(pre-commit): autofix * add diagnostic convertor in launch Signed-off-by: kyoichi-sugahara <[email protected]> * ci(pre-commit): autofix * change debug from info Signed-off-by: kyoichi-sugahara <[email protected]> * change arg name to launch diagnostic convertor * add planning_evaluator launcher in simulator.launch.xml Signed-off-by: kyoichi-sugahara <[email protected]> * fix arg wrong setting Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * use simulation msg in tier4_autoware_msgs Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * fix README Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * refactoring Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * remove unnecessary dependency Signed-off-by: kyoichi-sugahara <[email protected]> * remove unnecessary dependency Signed-off-by: kyoichi-sugahara <[email protected]> * move folder Signed-off-by: kyoichi-sugahara <[email protected]> * reformat Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * Update evaluator/diagnostic_converter/include/converter_node.hpp Co-authored-by: Maxime CLEMENT <[email protected]> * Update evaluator/diagnostic_converter/README.md Co-authored-by: Maxime CLEMENT <[email protected]> * Update evaluator/diagnostic_converter/src/converter_node.cpp Co-authored-by: Maxime CLEMENT <[email protected]> * Update evaluator/diagnostic_converter/test/test_converter_node.cpp Co-authored-by: Maxime CLEMENT <[email protected]> * define diagnostic_topics as parameter Signed-off-by: kyoichi-sugahara <[email protected]> * fix include way Signed-off-by: kyoichi-sugahara <[email protected]> * fix include way Signed-off-by: kyoichi-sugahara <[email protected]> * delete ament_cmake_clang_format from package.xml Signed-off-by: kyoichi-sugahara <[email protected]> * fix test_depend Signed-off-by: kyoichi-sugahara <[email protected]> * Update evaluator/diagnostic_converter/test/test_converter_node.cpp Co-authored-by: Maxime CLEMENT <[email protected]> * style(pre-commit): autofix * Update launch/tier4_simulator_launch/launch/simulator.launch.xml Co-authored-by: Maxime CLEMENT <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Maxime CLEMENT <[email protected]>
… output for scenario's condition (autowarefoundation#2514) * add original diagnostic_convertor Signed-off-by: kyoichi-sugahara <[email protected]> * add test Signed-off-by: kyoichi-sugahara <[email protected]> * fix typo Signed-off-by: kyoichi-sugahara <[email protected]> * delete file Signed-off-by: kyoichi-sugahara <[email protected]> * change include Signed-off-by: kyoichi-sugahara <[email protected]> * temp Signed-off-by: kyoichi-sugahara <[email protected]> * delete comments Signed-off-by: kyoichi-sugahara <[email protected]> * made launch for converter Signed-off-by: kyoichi-sugahara <[email protected]> * ci(pre-commit): autofix * ci(pre-commit): autofix * add diagnostic convertor in launch Signed-off-by: kyoichi-sugahara <[email protected]> * ci(pre-commit): autofix * change debug from info Signed-off-by: kyoichi-sugahara <[email protected]> * change arg name to launch diagnostic convertor * add planning_evaluator launcher in simulator.launch.xml Signed-off-by: kyoichi-sugahara <[email protected]> * fix arg wrong setting Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * use simulation msg in tier4_autoware_msgs Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * fix README Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * refactoring Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * remove unnecessary dependency Signed-off-by: kyoichi-sugahara <[email protected]> * remove unnecessary dependency Signed-off-by: kyoichi-sugahara <[email protected]> * move folder Signed-off-by: kyoichi-sugahara <[email protected]> * reformat Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * Update evaluator/diagnostic_converter/include/converter_node.hpp Co-authored-by: Maxime CLEMENT <[email protected]> * Update evaluator/diagnostic_converter/README.md Co-authored-by: Maxime CLEMENT <[email protected]> * Update evaluator/diagnostic_converter/src/converter_node.cpp Co-authored-by: Maxime CLEMENT <[email protected]> * Update evaluator/diagnostic_converter/test/test_converter_node.cpp Co-authored-by: Maxime CLEMENT <[email protected]> * define diagnostic_topics as parameter Signed-off-by: kyoichi-sugahara <[email protected]> * fix include way Signed-off-by: kyoichi-sugahara <[email protected]> * fix include way Signed-off-by: kyoichi-sugahara <[email protected]> * delete ament_cmake_clang_format from package.xml Signed-off-by: kyoichi-sugahara <[email protected]> * fix test_depend Signed-off-by: kyoichi-sugahara <[email protected]> * Update evaluator/diagnostic_converter/test/test_converter_node.cpp Co-authored-by: Maxime CLEMENT <[email protected]> * style(pre-commit): autofix * Update launch/tier4_simulator_launch/launch/simulator.launch.xml Co-authored-by: Maxime CLEMENT <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Maxime CLEMENT <[email protected]>
Description
background
diagnostic_msgs::msg::DiagnosticArray
can't be understood by scenario_simulator_v2 directly.diagnostic_msgs::msg::DiagnosticArray
totier4_simulator_msgs::msg::UserDefinedValue
which can be understood by scenario_simulator_v2 is implemented.discussuion
UserDefinedValue
msg is originally included in scenario_simulator_v2 repositorynode diagram and interface between with
scenario_simulator_v2
Proposal in related PRs
UserDefinedValue
msg out from scenario_simulator_v2 and tried to make repository for the msg. We noticed this is not the only option with the comment and we decided to add this msg intier4_autoware_msgs
. You can check discussion in this PRRelated PRs
tier4/tier4_autoware_msgs#73: Adding new message type
UserDefinedValue
andUserDefinedValueCondition
to packagetier4_simulation_msgs
autowarefoundation/autoware_launch#219: Adding argument so that
planning_evaluator
node will be launched whenscenario_simulator_v2
is running.tier4/scenario_simulator_v2#874: modify scenario_simulator_v2 so that the output from convertor node cen be understood by
scenario_simulator_v2
.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.
In-review checklist for the PR reviewers
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.