Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_planning_launch): remove configs and move to autoware_launch #2543

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 20, 2022

Description

Move config to autoware_launch.

Two PRs should be merged at the same time.
autowarefoundation/autoware_launch#133

autowarefoundation/autoware_launch#66

Launch planning_simulator.launch.xml and verified that all the nodes in /planning/* are launched successfully.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 20, 2022
@takayuki5168 takayuki5168 marked this pull request as ready for review December 20, 2022 11:06
@takayuki5168 takayuki5168 changed the title Feat/planning/add component launch in autoware launch feat(tier4_planning_launch): remove configs and move to autoware_launch Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 10.55% // Head: 10.54% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2c61ff4) compared to base (febbc13).
Patch has no changes to coverable lines.

❗ Current head 2c61ff4 differs from pull request most recent head 8bafc60. Consider uploading reports for the commit 8bafc60 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2543      +/-   ##
==========================================
- Coverage   10.55%   10.54%   -0.01%     
==========================================
  Files        1267     1266       -1     
  Lines       87599    87648      +49     
  Branches    20938    20937       -1     
==========================================
  Hits         9242     9242              
- Misses      68492    68543      +51     
+ Partials     9865     9863       -2     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 10.54% <ø> (-0.01%) ⬇️ Carriedforward from 418d8e5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...planning_evaluator/src/planning_evaluator_node.cpp 34.37% <0.00%> (-2.09%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 3.68% <0.00%> (-0.04%) ⬇️
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
planning/obstacle_cruise_planner/src/utils.cpp 0.00% <0.00%> (ø)
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
...eption/map_based_prediction/src/path_generator.cpp 0.00% <0.00%> (ø)
...ning/obstacle_cruise_planner/src/polygon_utils.cpp 0.00% <0.00%> (ø)
...ol/operation_mode_transition_manager/src/state.cpp 0.00% <0.00%> (ø)
...ol/operation_mode_transition_manager/src/state.hpp 0.00% <0.00%> (ø)
...tion/traffic_light_classifier/utils/trt_common.cpp 0.00% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the feat/planning/add_component_launch_in_autoware_launch branch from 31196f6 to d8a76ad Compare December 21, 2022 07:45
@takayuki5168 takayuki5168 merged commit 429f1ed into autowarefoundation:main Dec 21, 2022
@takayuki5168 takayuki5168 deleted the feat/planning/add_component_launch_in_autoware_launch branch December 21, 2022 08:02
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Dec 22, 2022
…ch (autowarefoundation#2543)

* feat(tier4_planning_launch): remove configs and move to autoware_launch

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* remove config

Signed-off-by: Takayuki Murooka <[email protected]>

* add rtc

Signed-off-by: Takayuki Murooka <[email protected]>

* Update launch/tier4_planning_launch/README.md

Co-authored-by: kminoda <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
Co-authored-by: kminoda <[email protected]>
kminoda added a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…ch (autowarefoundation#2543)

* feat(tier4_planning_launch): remove configs and move to autoware_launch

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* remove config

Signed-off-by: Takayuki Murooka <[email protected]>

* add rtc

Signed-off-by: Takayuki Murooka <[email protected]>

* Update launch/tier4_planning_launch/README.md

Co-authored-by: kminoda <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
Co-authored-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants