-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mission_planner): set goal in shoulder lane #2548
fix(mission_planner): set goal in shoulder lane #2548
Conversation
0dcc972
to
e43a144
Compare
hi @kosuke55, with this PR goal footprint will not checked at shoulder lanelet. Let discuss #2546 (comment) It make more sense to me update default map shoulder lanelet's width greater than vehicle length. What do you think? You can visualize goal pose footprint on this topic: |
Codecov ReportBase: 10.55% // Head: 10.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
=======================================
Coverage 10.55% 10.55%
=======================================
Files 1267 1267
Lines 87598 87598
Branches 20938 20938
=======================================
Hits 9242 9242
Misses 68493 68493
Partials 9863 9863
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
db2a178
to
85bb3ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
85bb3ec
to
e02d47e
Compare
Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: kosuke55 <[email protected]>
e02d47e
to
9b0888c
Compare
) * fix(mission_planner): set goal in shoulder lane Signed-off-by: kosuke55 <[email protected]> * fix map without shoulder lane Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
) * fix(mission_planner): set goal in shoulder lane Signed-off-by: kosuke55 <[email protected]> * fix map without shoulder lane Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
) (#223) * fix(mission_planner): set goal in shoulder lane Signed-off-by: kosuke55 <[email protected]> * fix map without shoulder lane Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Kosuke Takeuchi <[email protected]>
) * fix(mission_planner): set goal in shoulder lane Signed-off-by: kosuke55 <[email protected]> * fix map without shoulder lane Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kminoda <[email protected]>
Description
With #2088, goal can not be set in shoulder lane.
goal_in_shoulder-2022-12-21_03.38.02.mp4
In this PR, check goal for shoulder at first in
is_goal_valid
.Related links
#2088
Tests performed
psim
goal_in_shoulder-2022-12-21_03.50.27.mp4
tier4 internal scenario test
816/825
(result of 2022/12/21 daily test : 812/825)
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.