Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(motion_utils): add code owners #2564

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 22, 2022

Signed-off-by: kosuke55 [email protected]

Description

add
@kosuke55
@TakaHoribe
@rej55
@tkimura4
to motion_uitils code owners

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 22, 2022
@kosuke55
Copy link
Contributor Author

@takayuki5168 @purewater0901 @satoshi-ota
It's ok to add code owners?

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 enabled auto-merge (squash) December 22, 2022 06:52
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 10.55% // Head: 10.55% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ded9eb3) compared to base (8bdfe7c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2564      +/-   ##
==========================================
- Coverage   10.55%   10.55%   -0.01%     
==========================================
  Files        1268     1268              
  Lines       87604    87621      +17     
  Branches    20931    20931              
==========================================
  Hits         9246     9246              
- Misses      68495    68512      +17     
  Partials     9863     9863              
Flag Coverage Δ *Carryforward flag
differential 10.88% <ø> (?)
total 10.55% <ø> (ø) Carriedforward from 8bdfe7c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...n_planner/src/lanelet2_plugins/default_planner.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 6feb52a into autowarefoundation:main Dec 22, 2022
@kosuke55 kosuke55 deleted the chore/motion_utils_code_owner branch December 22, 2022 07:47
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
Signed-off-by: kosuke55 <[email protected]>

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: kminoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants