Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_avoidance_planner): add fitting_uniform_circle configuration for mpt #2646

Conversation

mehmetdogru
Copy link
Contributor

@mehmetdogru mehmetdogru commented Jan 12, 2023

Description


This PR aims to add an optimization circle configuration for MPT.

circle_conf-new_configs_1 drawio

Related links

Tests performed

fitting_uniform_circle.mp4

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mehmetdogru mehmetdogru added type:new-feature New functionalities or additions, feature requests. component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 12, 2023
@mehmetdogru mehmetdogru added this to the Bus ODD Jan-Feb Milestone milestone Jan 12, 2023
@mehmetdogru mehmetdogru self-assigned this Jan 12, 2023
@mehmetdogru mehmetdogru requested a review from a team as a code owner January 12, 2023 19:47
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 11.39% // Head: 11.34% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (69ff888) compared to base (966ef94).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2646      +/-   ##
==========================================
- Coverage   11.39%   11.34%   -0.05%     
==========================================
  Files        1277     1277              
  Lines       89182    89565     +383     
  Branches    23604    23923     +319     
==========================================
+ Hits        10161    10162       +1     
- Misses      68251    68593     +342     
- Partials    10770    10810      +40     
Flag Coverage Δ *Carryforward flag
differential 17.56% <0.00%> (?)
total 11.39% <0.00%> (ø) Carriedforward from 966ef94

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_avoidance_planner/src/node.cpp 0.17% <0.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmetdogru mehmetdogru merged commit 9e9beb8 into autowarefoundation:main Jan 18, 2023
@mehmetdogru mehmetdogru deleted the feat/mpt/add-fitting-uniform-circle-config branch January 18, 2023 22:17
voltonomous added a commit to vautonomous/autoware.universe that referenced this pull request Jan 20, 2023
…ation for mpt (autowarefoundation#2646)

* feat(obstacle_avoidance_planner): add fitting uniform circle configuration to mpt

Signed-off-by: Mehmet Dogru <[email protected]>

* feat: add update param

Signed-off-by: Mehmet Dogru <[email protected]>

Signed-off-by: Mehmet Dogru <[email protected]>
voltonomous added a commit to vautonomous/autoware.universe that referenced this pull request Jan 26, 2023
…ation for mpt (autowarefoundation#2646)

* feat(obstacle_avoidance_planner): add fitting uniform circle configuration to mpt

Signed-off-by: Mehmet Dogru <[email protected]>

* feat: add update param

Signed-off-by: Mehmet Dogru <[email protected]>

Signed-off-by: Mehmet Dogru <[email protected]>
add fitting circle config

Signed-off-by: Mehmet Dogru <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…ation for mpt (autowarefoundation#2646)

* feat(obstacle_avoidance_planner): add fitting uniform circle configuration to mpt

Signed-off-by: Mehmet Dogru <[email protected]>

* feat: add update param

Signed-off-by: Mehmet Dogru <[email protected]>

Signed-off-by: Mehmet Dogru <[email protected]>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…ation for mpt (autowarefoundation#2646)

* feat(obstacle_avoidance_planner): add fitting uniform circle configuration to mpt

Signed-off-by: Mehmet Dogru <[email protected]>

* feat: add update param

Signed-off-by: Mehmet Dogru <[email protected]>

Signed-off-by: Mehmet Dogru <[email protected]>
Signed-off-by: Alexey Panferov <[email protected]>
brkay54 pushed a commit to vautonomous/autoware.universe that referenced this pull request Feb 2, 2023
…ation for mpt (autowarefoundation#2646)

* feat(obstacle_avoidance_planner): add fitting uniform circle configuration to mpt

Signed-off-by: Mehmet Dogru <[email protected]>

* feat: add update param

Signed-off-by: Mehmet Dogru <[email protected]>

Signed-off-by: Mehmet Dogru <[email protected]>
add fitting circle config

Signed-off-by: Mehmet Dogru <[email protected]>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 30, 2023
…ation for mpt (autowarefoundation#2646)

* feat(obstacle_avoidance_planner): add fitting uniform circle configuration to mpt

Signed-off-by: Mehmet Dogru <[email protected]>

* feat: add update param

Signed-off-by: Mehmet Dogru <[email protected]>

Signed-off-by: Mehmet Dogru <[email protected]>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 3, 2023
* feat(obstacle_avoidance_planner): add fitting_uniform_circle configuration for mpt (autowarefoundation#2646)

* feat(obstacle_avoidance_planner): add fitting uniform circle configuration to mpt

Signed-off-by: Mehmet Dogru <[email protected]>

* feat: add update param

Signed-off-by: Mehmet Dogru <[email protected]>

Signed-off-by: Mehmet Dogru <[email protected]>

* fix(obstacle_avoidance_planner): consider soft clearance from road

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Mehmet Dogru <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Co-authored-by: Mehmet Dogru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants