Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_planning_launch): organize arguments #2666

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 17, 2023

Signed-off-by: Takayuki Murooka [email protected]

Description

organized arguments of tier4_planning_launch for tier4's reference designs' integration.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 11.38% // Head: 11.36% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9423781) compared to base (2eafda6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2666      +/-   ##
==========================================
- Coverage   11.38%   11.36%   -0.03%     
==========================================
  Files        1277     1277              
  Lines       89230    89427     +197     
  Branches    23619    23746     +127     
==========================================
+ Hits        10160    10161       +1     
- Misses      68297    68474     +177     
- Partials    10773    10792      +19     
Flag Coverage Δ *Carryforward flag
differential 4.95% <ø> (?)
total 11.38% <ø> (ø) Carriedforward from cf6b383

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...anner/src/scene_module/pull_over/goal_searcher.cpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.26% <0.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168
Copy link
Contributor Author

@TakaHoribe Could you review the PR.
I confirmed that psim worked well with this PR.

@takayuki5168 takayuki5168 merged commit 6651892 into autowarefoundation:main Jan 18, 2023
@takayuki5168 takayuki5168 deleted the refactor/tier4-planning-launch-param branch January 18, 2023 01:47
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…on#2666)

* refactor(tier4_planning_launch): organize arguments

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants