Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_loader): apply clang-tidy #2668

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 17, 2023

Signed-off-by: kminoda [email protected]

Description

Apply clang-tidy to pointcloud_map_loader

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Jan 17, 2023
@kminoda kminoda marked this pull request as ready for review January 17, 2023 08:37
Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 11.38% // Head: 11.38% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2ce563e) compared to base (1d39c6c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2668      +/-   ##
==========================================
- Coverage   11.38%   11.38%   -0.01%     
==========================================
  Files        1277     1277              
  Lines       89231    89237       +6     
  Branches    23619    23624       +5     
==========================================
  Hits        10163    10163              
- Misses      68297    68301       +4     
- Partials    10771    10773       +2     
Flag Coverage Δ *Carryforward flag
differential 22.93% <0.00%> (?)
total 11.38% <0.00%> (ø) Carriedforward from 1d39c6c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...loud_map_loader/differential_map_loader_module.cpp 0.00% <0.00%> (ø)
...ointcloud_map_loader/partial_map_loader_module.cpp 0.00% <ø> (ø)
...tcloud_map_loader/pointcloud_map_loader_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kminoda kminoda merged commit ef51734 into autowarefoundation:main Jan 18, 2023
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
* fix(map_loader): apply clang-tidy

Signed-off-by: kminoda <[email protected]>

* ci(pre-commit): autofix

Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 4, 2023
* fix(map_loader): apply clang-tidy

Signed-off-by: kminoda <[email protected]>

* ci(pre-commit): autofix

Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kminoda kminoda deleted the fix/map_loader/clang-tidy branch August 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants