Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): change vehicle model from constant velocity and turn rate model to bicycle model #2679

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Jan 18, 2023

Description

Applied bicycle model to avoid unnecessarily yaw rotation when the estimated object speed is small.

image

  • state variable
    • pose( $x,y$ ), velocity( $v$ ), yaw( $\psi$ ), and slip angle ( $\beta$ )
    • $[x_{k} ,y_{k} , v_{k} , \psi_{k} , \beta_{k} ]^\mathrm{T}$
  • Prediction Equation
    • $dt$: sampling time

$$ \begin{aligned} x_{k+1} & =x_{k}+v_{k} \cos \left(\varphi_{k}+\beta_{k}\right) d t \\ y_{k+1} & =y_{k}+v_{k} \sin \left(\varphi_{k}+\beta_{k}\right) d t \\ v_{k+1} & =v_{k} \\ \varphi_{k+1} & =\varphi_{k}+\frac{v_{k}}{l_{n}} \sin \beta_{k} d t \\ \beta_{k+1} & =\beta_{k} \end{aligned} $$

  • Jacobian

$$ \frac{\partial f}{\partial \mathrm x}=\left[\begin{array}{ccccc} 1 & 0 & -v \sin (\varphi+\beta) d t & v \cos (\varphi+\beta) & -v \sin (\varphi+\beta) d t \\ 0 & 1 & v \cos (\varphi+\beta) d t & v \sin (\varphi+\beta) & v \cos (\varphi+\beta) d t \\ 0 & 0 & 1 & \frac{1}{\operatorname{lr}} \sin \beta d t & \frac{v}{\operatorname{lr}} \cos \beta d t \\ 0 & 0 & 0 & 1 & 0 \\ 0 & 0 & 0 & 0 & 1 \end{array}\right] $$

  • Target objects
    • bicycle, normal_vehicle, large_vehicle

Related links

Tests performed

Before

mock_orig_bike-2023-01-18_14.13.47.mp4

After

mock_fix_bike-2023-01-18_17.10.15.mp4

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi YoshiRi requested review from yukkysaito and a team as code owners January 18, 2023 08:12
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 18, 2023
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Jan 18, 2023

We still have the following TODOs regarding this feature, but I thought that it is better to improve the tracking behavior as soon as possible, so I have created a PR for the time being.

  • Refactoring source code (models should be defined in another file)
  • Parameter tuning

@YoshiRi YoshiRi changed the title feature(multi_object_tracker): change vehicle model from CVTR to bicycle model feat(multi_object_tracker): change vehicle model from CVTR to bicycle model Jan 18, 2023
@YoshiRi YoshiRi changed the title feat(multi_object_tracker): change vehicle model from CVTR to bicycle model feat(multi_object_tracker): change vehicle model from constant velocity and turn rate model to bicycle model Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 11.39% // Head: 11.35% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (893f056) compared to base (33ecdb5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2679      +/-   ##
==========================================
- Coverage   11.39%   11.35%   -0.05%     
==========================================
  Files        1279     1279              
  Lines       89170    89491     +321     
  Branches    23587    23587              
==========================================
  Hits        10161    10161              
- Misses      68239    68560     +321     
  Partials    10770    10770              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.39% <0.00%> (ø) Carriedforward from 33ecdb5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...i_object_tracker/tracker/model/bicycle_tracker.hpp 0.00% <0.00%> (ø)
...ject_tracker/tracker/model/big_vehicle_tracker.hpp 0.00% <0.00%> (ø)
...t_tracker/tracker/model/normal_vehicle_tracker.hpp 0.00% <0.00%> (ø)
...ject_tracker/src/tracker/model/bicycle_tracker.cpp 0.00% <0.00%> (ø)
..._tracker/src/tracker/model/big_vehicle_tracker.cpp 0.00% <0.00%> (ø)
...acker/src/tracker/model/normal_vehicle_tracker.cpp 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit 1a99f54 into autowarefoundation:main Jan 19, 2023
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…ty and turn rate model to bicycle model (autowarefoundation#2679)

* try bicycle model

Signed-off-by: yoshiri <[email protected]>

* apply bicycle model to bicycle tracker

Signed-off-by: yoshiri <[email protected]>

Signed-off-by: yoshiri <[email protected]>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…ty and turn rate model to bicycle model (autowarefoundation#2679)

* try bicycle model

Signed-off-by: yoshiri <[email protected]>

* apply bicycle model to bicycle tracker

Signed-off-by: yoshiri <[email protected]>

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: Alexey Panferov <[email protected]>
@YoshiRi YoshiRi deleted the feature/MOT_model_update branch February 17, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants