Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(planning_validator): fix typo #2707

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jan 20, 2023

Description

fix typo

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe TakaHoribe requested a review from wep21 January 20, 2023 10:45
@TakaHoribe TakaHoribe marked this pull request as ready for review January 20, 2023 10:45
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 11.35% // Head: 11.58% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (f95d923) compared to base (fee4d11).
Patch coverage: 45.84% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2707      +/-   ##
==========================================
+ Coverage   11.35%   11.58%   +0.22%     
==========================================
  Files        1279     1288       +9     
  Lines       89462    90051     +589     
  Branches    23678    23955     +277     
==========================================
+ Hits        10161    10431     +270     
- Misses      68531    68645     +114     
- Partials    10770    10975     +205     
Flag Coverage Δ *Carryforward flag
differential 45.84% <45.84%> (?)
total 11.35% <ø> (ø) Carriedforward from fee4d11

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...jectory_publisher/invalid_trajectory_publisher.cpp 0.00% <0.00%> (ø)
...idator/test/src/test_planning_validator_pubsub.cpp 35.29% <35.29%> (ø)
...idator/test/src/test_planning_validator_helper.cpp 37.93% <37.93%> (ø)
...ning/planning_validator/src/planning_validator.cpp 45.60% <45.60%> (ø)
...tor/test/src/test_planning_validator_functions.cpp 50.94% <50.94%> (ø)
planning/planning_validator/src/utils.cpp 54.90% <54.90%> (ø)
planning/planning_validator/src/debug_marker.cpp 65.00% <65.00%> (ø)
planning/planning_validator/test/src/test_main.cpp 66.66% <66.66%> (ø)
...idator/include/planning_validator/debug_marker.hpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit e94ff60 into autowarefoundation:main Jan 20, 2023
@TakaHoribe TakaHoribe deleted the fix-typo-planning-validator branch January 20, 2023 14:34
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Alexey Panferov <[email protected]>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 9, 2023
Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants