-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lane_change): fix bug when target reference path is empty #2752
fix(lane_change): fix bug when target reference path is empty #2752
Conversation
Signed-off-by: tomoya.kimura <[email protected]>
planning/behavior_path_planner/src/scene_module/lane_change/util.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: tomoya.kimura <[email protected]>
Codecov ReportBase: 11.64% // Head: 11.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2752 +/- ##
==========================================
- Coverage 11.64% 11.62% -0.02%
==========================================
Files 1312 1312
Lines 91445 91593 +148
Branches 24342 24441 +99
==========================================
+ Hits 10646 10649 +3
- Misses 69683 69826 +143
- Partials 11116 11118 +2
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…refoundation#2752) * fix(lane_change): fix bug when target reference path is empty Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]>
…refoundation#2752) (#256) * fix(lane_change): fix bug when target reference path is empty Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]>
…refoundation#2752) * fix(lane_change): fix bug when target reference path is empty Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]>
…refoundation#2752) * fix(lane_change): fix bug when target reference path is empty Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: Alexey Panferov <[email protected]>
…refoundation#2752) * fix(lane_change): fix bug when target reference path is empty Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]>
Signed-off-by: tomoya.kimura [email protected]
Description
When target_lane_reference_path is empty, behavior_path_planner dies with the following error.
I fixed it.
( Note: In the external lane change module, the reference path is often empty )
Related links
(TIER IV Internal Link) evaluator https://evaluation.tier4.jp/evaluation/reports/4ec045cd-5fea-550e-a4a9-9315ccfc19a0/tests/4874d7ea-2934-5bba-863b-812de0c2bcac/ca5874a9-7b72-5568-88cb-af3c42bc4371/ea2a9252-30df-548e-99f9-6bed698ded47?project_id=prd_jt
Tests performed
I confirmed that the behavior module does not die with merging this PR using the planning simulator.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.