Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): fix bug when target reference path is empty #2752

Merged

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Jan 26, 2023

Signed-off-by: tomoya.kimura [email protected]

Description

When target_lane_reference_path is empty, behavior_path_planner dies with the following error.
I fixed it.
image
( Note: In the external lane change module, the reference path is often empty )
image

Related links

(TIER IV Internal Link) evaluator https://evaluation.tier4.jp/evaluation/reports/4ec045cd-5fea-550e-a4a9-9315ccfc19a0/tests/4874d7ea-2934-5bba-863b-812de0c2bcac/ca5874a9-7b72-5568-88cb-af3c42bc4371/ea2a9252-30df-548e-99f9-6bed698ded47?project_id=prd_jt

Tests performed

I confirmed that the behavior module does not die with merging this PR using the planning simulator.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 26, 2023
Signed-off-by: tomoya.kimura <[email protected]>
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 11.64% // Head: 11.62% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (cb5b424) compared to base (7ac518f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2752      +/-   ##
==========================================
- Coverage   11.64%   11.62%   -0.02%     
==========================================
  Files        1312     1312              
  Lines       91445    91593     +148     
  Branches    24342    24441      +99     
==========================================
+ Hits        10646    10649       +3     
- Misses      69683    69826     +143     
- Partials    11116    11118       +2     
Flag Coverage Δ *Carryforward flag
differential 4.70% <0.00%> (?)
total 11.64% <0.00%> (+<0.01%) ⬆️ Carriedforward from d5a1f96

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 88.09% <0.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 23ad8eb into autowarefoundation:main Jan 26, 2023
@tkimura4 tkimura4 deleted the fix/external_lane_change_empty_path branch January 26, 2023 05:27
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jan 26, 2023
…refoundation#2752)

* fix(lane_change): fix bug when target reference path is empty

Signed-off-by: tomoya.kimura <[email protected]>

* fix

Signed-off-by: tomoya.kimura <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jan 26, 2023
…refoundation#2752) (#256)

* fix(lane_change): fix bug when target reference path is empty

Signed-off-by: tomoya.kimura <[email protected]>

* fix

Signed-off-by: tomoya.kimura <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…refoundation#2752)

* fix(lane_change): fix bug when target reference path is empty

Signed-off-by: tomoya.kimura <[email protected]>

* fix

Signed-off-by: tomoya.kimura <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…refoundation#2752)

* fix(lane_change): fix bug when target reference path is empty

Signed-off-by: tomoya.kimura <[email protected]>

* fix

Signed-off-by: tomoya.kimura <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
Signed-off-by: Alexey Panferov <[email protected]>
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
…refoundation#2752)

* fix(lane_change): fix bug when target reference path is empty

Signed-off-by: tomoya.kimura <[email protected]>

* fix

Signed-off-by: tomoya.kimura <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants