Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lanelet2_map_loader): delete unused parameters #2761

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Jan 27, 2023

Description

In #954, I added following parameters in lanelet2_map_loader.param.yaml.

  • lanelet2_map_projector_type
  • center_line_resolution

However, I forget to delete from lanelet2_map_loader.launch.xml.
I fix it.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 11.64% // Head: 11.64% // No change to project coverage 👍

Coverage data is based on head (fbdc523) compared to base (d5a627e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2761   +/-   ##
=======================================
  Coverage   11.64%   11.64%           
=======================================
  Files        1312     1312           
  Lines       91430    91430           
  Branches    24327    24327           
=======================================
  Hits        10646    10646           
  Misses      69668    69668           
  Partials    11116    11116           
Flag Coverage Δ *Carryforward flag
differential 22.93% <ø> (?)
total 11.64% <ø> (ø) Carriedforward from d5a627e

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit 2a13d30 into main Jan 30, 2023
@h-ohta h-ohta deleted the fix/lanelet2_map_loader branch January 30, 2023 00:40
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…n#2761)

* fix(lanelet2_map_loader): delete unused parameters

* Update lanelet2_map_loader.launch.xml
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…n#2761)

* fix(lanelet2_map_loader): delete unused parameters

* Update lanelet2_map_loader.launch.xml

Signed-off-by: Alexey Panferov <[email protected]>
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
…n#2761)

* fix(lanelet2_map_loader): delete unused parameters

* Update lanelet2_map_loader.launch.xml
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 4, 2023
…n#2761)

* fix(lanelet2_map_loader): delete unused parameters

* Update lanelet2_map_loader.launch.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants