chore(tier4_planning_launch): add missing params and sort params of costmap generator #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
rej55,
kyoichi-sugahara,
mkuri,
soblin,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
TomohitoAndo,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
…ostmap generator Signed-off-by: kosuke55 <[email protected]>
github-actions
bot
added
the
component:launch
kosuke55
force-pushed
the
chore/tier4_planning_launch
branch
from
cc75dd4
to
d486f1f
Compare
kosuke55
changed the title
TakaHoribe
approved these changes
Jan 31, 2023
TakaHoribe
approved these changes
Jan 31, 2023
lexavtanke
pushed a commit
to lexavtanke/autoware.universe
that referenced
this pull request
Jan 31, 2023
…ostmap generator (autowarefoundation#2764) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: Alexey Panferov <[email protected]>
asana17
pushed a commit
to asana17/autoware.universe
that referenced
this pull request
Feb 8, 2023
…ostmap generator (autowarefoundation#2764) Signed-off-by: kosuke55 <[email protected]>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 14, 2023
…ostmap generator (autowarefoundation#2764) Signed-off-by: kosuke55 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kosuke55 [email protected]
Description
Add
activate_by_scenariowhich is added #692 to parking.launch and sort the params same to the order of costmap_generator_node.cpp#692
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.