Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(control): add autonomous emergency braking module #2793

Merged
merged 31 commits into from
Mar 17, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Feb 1, 2023

Description

Currently, autoware does not have any emergency braking systems, and it can be collide obstacles when ego vehicle is out of the lane or ego position is not accurate. In this PR, I created a new package called "autonomous emergency braking", and it enables Autoware to stop ego vehicle when emergency brake needed.

This new function has the following features.

  • Generate predicted path of the ego vehicle from imu data (steering angle) and vehicle velocity data
  • Perform collision check with pointcloud data using path generated by the aformentioned method or (and) predicted path from control module
  • Send error signals via diagnostics when collision happens

Related links

Tests performed

This function is tested with real vehicle, and the author confirms AEB works correctly.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned) labels Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (7d15fdf) 11.65% compared to head (d386e54) 11.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2793      +/-   ##
==========================================
+ Coverage   11.65%   11.70%   +0.04%     
==========================================
  Files        1314     1317       +3     
  Lines       92818    90910    -1908     
  Branches    25008    24030     -978     
==========================================
- Hits        10821    10643     -178     
+ Misses      70646    69202    -1444     
+ Partials    11351    11065     -286     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.73% <ø> (+0.07%) ⬆️ Carriedforward from cff916b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
control/autonomous_emergency_braking/src/node.cpp 0.00% <0.00%> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 0.00% <0.00%> (-21.43%) ⬇️
...ion/include/interpolation/spline_interpolation.hpp 28.57% <0.00%> (-13.10%) ⬇️
...zation/ekf_localizer/test/test_warning_message.cpp 54.54% <0.00%> (-4.28%) ⬇️
...e/interpolation/spline_interpolation_points_2d.hpp 80.00% <0.00%> (-3.34%) ⬇️
...planning_evaluator/src/planning_evaluator_node.cpp 34.37% <0.00%> (-2.09%) ⬇️
...nning_simulator/simple_planning_simulator_core.cpp 37.42% <0.00%> (-1.96%) ⬇️
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 43.54% <0.00%> (-0.82%) ⬇️
...n_utils/test/src/trajectory/test_interpolation.cpp 17.34% <0.00%> (-0.82%) ⬇️
...ing/obstacle_avoidance_planner/src/utils/utils.cpp 9.93% <0.00%> (-0.67%) ⬇️
... and 208 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

purewater0901 and others added 8 commits February 6, 2023 00:55
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Feb 8, 2023
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
@github-actions github-actions bot removed the component:simulation Virtual environment setups and simulations. (auto-assigned) label Feb 28, 2023
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
@TakaHoribe
Copy link
Contributor

TakaHoribe commented Mar 16, 2023

memo: this node is not launched by default. autowarefoundation/autoware_launch#232

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: this feature could be merged into the node discussed here so that some additional features such as the pause interface can be used.

@ito-san ito-san self-requested a review March 17, 2023 01:58
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 948a1d5 into autowarefoundation:main Mar 17, 2023
@purewater0901 purewater0901 deleted the feat/add-aeb-package branch March 17, 2023 02:08
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Mar 20, 2023
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Apr 13, 2023
…warefoundation#2793, autowarefoundation#3186, autowarefoundation#3248, autowarefoundation#3292) (#330)

* feat(control): add autonomous emergency braking module (autowarefoundation#2793)

* fix build error

* ci(pre-commit): autofix

* fix: fix lookup symbol error

* fix(autonomous_emergency_braking): fix typo (autowarefoundation#3186)

Update node.cpp

* fix(autonomous_emergency_braking): publish debug marker on base_link frame (autowarefoundation#3248)

* feat(autonomous_emergency_braking): keep collision information for user specified seconds (autowarefoundation#3292)

* feat(autonomous_emergency_braking): keep collision information for user specified seconds

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Co-authored-by: Yutaka Shimizu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants