-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vehicle status api #2930
Conversation
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
@isamu-takagi @KYabuuchi |
@tkhmy Since those functions will be reviewed by different people, it would be better to separate them if you can. |
@KYabuuchi |
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
a5f8f55
to
7cf22bb
Compare
common/autoware_ad_api_specs/include/autoware_ad_api_specs/vehicle.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
@isamu-takagi I fixed the naming and it should be working now. I think the autoware document currently do not have a link to the vehicle api page. can I create a PR for that? |
@tkhmy Thank you for checking document. I updated pages in this PR autowarefoundation/autoware-documentation#406. Now the vehicle status page is available from side menu.
Yes. The vehicle driver needs to support a interface for multiple doors. So for now, how about returning an empty array for status and layout? |
@isamu-takagi Thank you, I just saw the update, I think it is good
Actually I notice that vehicle interface do not have the message type for publishing multiple message, the current available is this tier4_api_msgs/msg/DoorStatus. I think we can ask define vehicle_interface to use the DoorStatusArray directly, then the api will just relay the topic. How do you think? |
Signed-off-by: tkhmy <[email protected]>
@tkhmy It sounds good. So we need to define interface for vehicle driver. It may be better to separate the PR for the door. |
@isamu-takagi Okay I will separate the door from this PR |
Signed-off-by: tkhmy <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2930 +/- ##
==========================================
+ Coverage 14.36% 14.38% +0.01%
==========================================
Files 1567 1568 +1
Lines 107877 111046 +3169
Branches 31249 33564 +2315
==========================================
+ Hits 15498 15972 +474
- Misses 75525 77664 +2139
- Partials 16854 17410 +556
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
common/component_interface_specs/include/component_interface_specs/vehicle.hpp
Outdated
Show resolved
Hide resolved
common/component_interface_specs/include/component_interface_specs/vehicle.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
@isamu-takagi I changed the stuff that you request and also fixed the conflict with main, can you review again? |
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
add publish mgrs_grip topic in the map_loader-> move to feat(map_loader): add publish map projector info #3200~~ - /api/vehicle/door ~~
Related links
Tests performed
/api/vehicle/kinematic
/localization/kinematic_state
->pose/localization/kinematic_state
->twist/localization/acceleration
-> accel/api/vehicle/state
/vehicle/status/steering_status
->steering_tire_angle/vehicle/status/gear_status
->report/vehicle/status/battery_charge
-> energy_levelros2 topic pub /vehicle/status/battery_charge tier4_vehicle_msgs/msg/BatteryStatus energy_level:\ 20
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.