-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ekf_localizer): move parameters to its dedicated yaml file #3039
chore(ekf_localizer): move parameters to its dedicated yaml file #3039
Conversation
Signed-off-by: Vincent Richard <[email protected]>
760a9a0
to
86c95b0
Compare
GJ!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot!
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3039 +/- ##
==========================================
- Coverage 11.88% 11.88% -0.01%
==========================================
Files 1336 1336
Lines 93197 93192 -5
Branches 24728 24727 -1
==========================================
- Hits 11077 11075 -2
+ Misses 70641 70637 -4
- Partials 11479 11480 +1
*This pull request uses carry forward flags. Click here to find out more. see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…owarefoundation#3039) * chores(ekf_localizer): move parameters to its dedicated yaml file Signed-off-by: Vincent Richard <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Vincent Richard <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
See #2958
Must be merged along with autowarefoundation/autoware_launch#244
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.