Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ekf_localizer): move parameters to its dedicated yaml file #3039

Merged
merged 5 commits into from
Mar 22, 2023

Conversation

VRichardJP
Copy link
Contributor

@VRichardJP VRichardJP commented Mar 9, 2023

Description

See #2958
Must be merged along with autowarefoundation/autoware_launch#244

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Mar 9, 2023
@YamatoAndo
Copy link
Contributor

GJ!!

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@kminoda kminoda changed the title chores(ekf_localizer): move parameters to its dedicated yaml file chore(ekf_localizer): move parameters to its dedicated yaml file Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (8b95d2a) 11.88% compared to head (afadeb9) 11.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3039      +/-   ##
==========================================
- Coverage   11.88%   11.88%   -0.01%     
==========================================
  Files        1336     1336              
  Lines       93197    93192       -5     
  Branches    24728    24727       -1     
==========================================
- Hits        11077    11075       -2     
+ Misses      70641    70637       -4     
- Partials    11479    11480       +1     
Flag Coverage Δ *Carryforward flag
differential 22.94% <ø> (?)
total 11.88% <ø> (-0.01%) ⬇️ Carriedforward from 1a9ce06

*This pull request uses carry forward flags. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mitsudome-r mitsudome-r enabled auto-merge (squash) March 20, 2023 02:46
@mitsudome-r mitsudome-r merged commit 61b9e1e into autowarefoundation:main Mar 22, 2023
@VRichardJP VRichardJP deleted the move_ekf_params branch March 22, 2023 07:30
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 4, 2023
…owarefoundation#3039)

* chores(ekf_localizer): move parameters to its dedicated yaml file

Signed-off-by: Vincent Richard <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Vincent Richard <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants