Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planning_test_utils): add planning interface test manager for some obstacle modules #3076

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Mar 14, 2023

Description

background

There are many cases where planning nodes die when they input an empty trajectory, a trajectory with only one point, or a trajectory where the points are duplicated.

purpose

To prevent these errors in advance, added tests to each node(some obstacle modules in this PR) to ensure that they do not crash when irregular trajectories is given. Confirmed that the process works properly by providing a normal trajectory as input before giving an irregular trajectory and outputting the necessary information for subsequent processing.

diagram

Here is an example of obstacle_cruise_planner_node and a diagram showing the test process.
The confirmation of normal operation is verified following the diagram and flow below.
Screenshot from 2023-03-14 17-53-41

Verification of behavior for irregular inputs is confirmed by following the diagram and flow below.
Screenshot from 2023-03-14 17-52-11

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

kyoichi-sugahara and others added 30 commits March 7, 2023 17:58
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
This reverts commit 6cd13f8.

Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 34.88% and project coverage change: +0.43 🎉

Comparison is base (f210e40) 11.92% compared to head (a073874) 12.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3076      +/-   ##
==========================================
+ Coverage   11.92%   12.35%   +0.43%     
==========================================
  Files        1332     1336       +4     
  Lines       92934    92937       +3     
  Branches    24735    26635    +1900     
==========================================
+ Hits        11079    11486     +407     
+ Misses      70376    69342    -1034     
- Partials    11479    12109     +630     
Flag Coverage Δ *Carryforward flag
differential 5.82% <34.88%> (?)
total 11.92% <ø> (+<0.01%) ⬆️ Carriedforward from 88bda80

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...test/test_obstacle_stop_planner_node_interface.cpp 10.52% <10.52%> (ø)
...st/test_obstacle_cruise_planner_node_interface.cpp 11.76% <11.76%> (ø)
..._manager/planning_interface_test_manager_utils.hpp 37.14% <37.14%> (ø)
...test_utils/src/planning_interface_test_manager.cpp 48.27% <48.27%> (ø)

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyoichi-sugahara Thank you for your work.
Overall, LGTM. The name manager sounds too much for this function. Could it be utils or something like that?

Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
Copy link
Contributor Author

@TakaHoribe
Thank you!
I changed package name and I have made the necessary changes to adapt to other modules and confirmed that the tests have passed.

@kyoichi-sugahara kyoichi-sugahara enabled auto-merge (squash) March 16, 2023 10:13
@kyoichi-sugahara kyoichi-sugahara changed the title feat(planning_test_manager): add planning interface test manager for some obstacle modules feat(planning_test_utils): add planning interface test manager for some obstacle modules Mar 16, 2023
@TomohitoAndo TomohitoAndo self-requested a review March 17, 2023 07:37
@kyoichi-sugahara kyoichi-sugahara merged commit de8cbdc into autowarefoundation:main Mar 23, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the test/planning_interface_test_obstacle_modules branch March 23, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants