refactor(scenario_selector): delete default values #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamazakiTasuku
requested review from
kosuke55,
takayuki5168,
a team,
rej55,
kenji-miyake,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
satoshi-ota
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3116 +/- ##
==========================================
- Coverage 12.25% 11.95% -0.30%
==========================================
Files 1358 1324 -34
Lines 94777 92113 -2664
Branches 26940 24625 -2315
==========================================
- Hits 11612 11012 -600
+ Misses 70888 69686 -1202
+ Partials 12277 11415 -862
*This pull request uses carry forward flags. Click here to find out more.
... and 129 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@yamazakiTasuku Could you fix conflicts? -> I fixed it. |
Signed-off-by: yamazakiTasuku <[email protected]>
satoshi-ota
force-pushed
the
scenario_selector_delete_param
branch
from
3f87771
to
ff30adc
Compare
satoshi-ota
approved these changes
Mar 31, 2023
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Apr 7, 2023
…n#3116) scenario_selector_delete_param Signed-off-by: yamazakiTasuku <[email protected]> Co-authored-by: yamazakiTasuku <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed default values defined in declare_parameter function.
scenario_selector_delete_param.webm
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.