-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(scenario_selector): delete default values #3116
refactor(scenario_selector): delete default values #3116
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3116 +/- ##
==========================================
- Coverage 12.25% 11.95% -0.30%
==========================================
Files 1358 1324 -34
Lines 94777 92113 -2664
Branches 26940 24625 -2315
==========================================
- Hits 11612 11012 -600
+ Misses 70888 69686 -1202
+ Partials 12277 11415 -862
*This pull request uses carry forward flags. Click here to find out more.
... and 129 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@yamazakiTasuku Could you fix conflicts? -> I fixed it. |
Signed-off-by: yamazakiTasuku <[email protected]>
3f87771
to
ff30adc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These params defalut value are defined here. LGTM.
autoware.universe/planning/scenario_selector/launch/scenario_selector.launch.xml
Lines 23 to 27 in a9ff35d
<param name="update_rate" value="10.0"/> | |
<param name="th_max_message_delay_sec" value="1.0"/> | |
<param name="th_arrived_distance_m" value="1.0"/> | |
<param name="th_stopped_time_sec" value="1.0"/> | |
<param name="th_stopped_velocity_mps" value="0.01"/> |
…n#3116) scenario_selector_delete_param Signed-off-by: yamazakiTasuku <[email protected]> Co-authored-by: yamazakiTasuku <[email protected]>
Description
Removed default values defined in declare_parameter function.
scenario_selector_delete_param.webm
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.