Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_centerline_optimizer): remove unnecessary files #3154

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 23, 2023

Description

Removed unnecessary files which are not used anymore.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 marked this pull request as ready for review March 23, 2023 07:46
@takayuki5168 takayuki5168 requested review from kosuke55 and a team as code owners March 23, 2023 07:46
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 23, 2023
@takayuki5168
Copy link
Contributor Author

@kosuke55 Could you approve the PR.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.83 ⚠️

Comparison is base (cf753f4) 13.14% compared to head (2af93d3) 12.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
- Coverage   13.14%   12.31%   -0.83%     
==========================================
  Files        1239     1340     +101     
  Lines       87524    93382    +5858     
  Branches    26744    26740       -4     
==========================================
  Hits        11502    11502              
- Misses      63871    69732    +5861     
+ Partials    12151    12148       -3     
Flag Coverage Δ *Carryforward flag
differential 29.28% <ø> (?)
total 12.31% <ø> (-0.83%) ⬇️ Carriedforward from de8cbdc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...luator/diagnostic_converter/src/converter_node.cpp 63.63% <ø> (+7.63%) ⬆️
...lanner/src/scene_module/detection_area/manager.cpp 0.00% <ø> (ø)
..._planner/src/scene_module/detection_area/scene.cpp 0.00% <ø> (ø)

... and 103 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 1469f52 into autowarefoundation:main Mar 23, 2023
@takayuki5168 takayuki5168 deleted the fix/remove-unnecessary-files-in-static-center-optimizer branch March 23, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants