Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_rviz_plugin): add bicycle panel #3157

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 23, 2023

Description

I added a tool to add a bicycle (or motorcycle) from rviz ui.

Screenshot from 2023-03-23 18-45-11

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@soblin soblin requested review from yukkysaito and a team as code owners March 23, 2023 09:48
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) labels Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.84 ⚠️

Comparison is base (cf753f4) 13.14% compared to head (730c7ca) 12.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3157      +/-   ##
==========================================
- Coverage   13.14%   12.30%   -0.84%     
==========================================
  Files        1239     1340     +101     
  Lines       87524    93459    +5935     
  Branches    26744    26744              
==========================================
  Hits        11502    11502              
- Misses      63871    69806    +5935     
  Partials    12151    12151              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 12.31% <ø> (-0.83%) ⬇️ Carriedforward from de8cbdc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ier4_perception_rviz_plugin/src/tools/car_pose.cpp 0.00% <0.00%> (ø)

... and 103 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit 572f39e into autowarefoundation:main Mar 23, 2023
@soblin soblin deleted the feat/dummy-bike-panel branch March 23, 2023 11:31
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
…tion#3157)

select motorcycle or bicycle and publish

Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants