Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_loader): address deprecated warning for some environment #3188

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Mar 28, 2023

Description

Some people got the following error. Although not everyone encounters this error, I would like to address this by small modification.

/home/.../pilot-auto/src/autoware/universe/map/map_loader/test/test_pointcloud_map_loader_module.cpp:84:81:   required from here
/opt/ros/humble/include/rclcpp/rclcpp/any_subscription_callback.hpp:391:21: error: 'void rclcpp::AnySubscriptionCallback<MessageT, AllocatorT>::set_deprecated(std::function<void(std::shared_ptr<_Yp>)>) [with SetT = sensor_msgs::msg::PointCloud2_<std::allocator<void> >; MessageT = sensor_msgs::msg::PointCloud2_<std::allocator<void> >; AllocatorT = std::allocator<void>]' is deprecated: use 'void(std::shared_ptr<const MessageT>)' instead [-Werror=deprecated-declarations]
  391 |       set_deprecated(static_cast<typename scbth::callback_type>(callback));
      |       ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/ros/humble/include/rclcpp/rclcpp/any_subscription_callback.hpp:408:3: note: declared here
  408 |   set_deprecated(std::function<void(std::shared_ptr<SetT>)> callback)
      |   ^~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
gmake[2]: *** [CMakeFiles/test_pointcloud_map_loader_module.dir/build.make:76: CMakeFiles/test_pointcloud_map_loader_module.dir/test/test_pointcloud_map_loader_module.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:383: CMakeFiles/test_pointcloud_map_loader_module.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< map_loader [12.4s, exited with code 2]

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda self-assigned this Mar 28, 2023
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Mar 28, 2023
@kminoda kminoda changed the title fix(map_loader): address deprecated warning for some version fix(map_loader): address deprecated warning for some environment Mar 28, 2023
@rej55 rej55 self-requested a review March 28, 2023 09:39
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1ef312b) 12.27% compared to head (efbf18f) 12.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3188   +/-   ##
=======================================
  Coverage   12.27%   12.27%           
=======================================
  Files        1358     1358           
  Lines       94666    94666           
  Branches    26858    26858           
=======================================
  Hits        11616    11616           
  Misses      70804    70804           
  Partials    12246    12246           
Flag Coverage Δ *Carryforward flag
differential 33.33% <ø> (?)
total 12.27% <ø> (ø) Carriedforward from 1ef312b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._loader/test/test_pointcloud_map_loader_module.cpp 45.45% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 767d057 into autowarefoundation:main Mar 28, 2023
@kminoda kminoda deleted the fix/map_loader/test_for_addressing_deprecated branch March 29, 2023 07:21
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 3, 2023
…owarefoundation#3188)

fix(map_loader): address deprecated warning for some version

Signed-off-by: kminoda <[email protected]>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 4, 2023
…owarefoundation#3188)

fix(map_loader): address deprecated warning for some version

Signed-off-by: kminoda <[email protected]>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 6, 2023
…owarefoundation#3188)

fix(map_loader): address deprecated warning for some version

Signed-off-by: kminoda <[email protected]>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…owarefoundation#3188)

fix(map_loader): address deprecated warning for some version

Signed-off-by: kminoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants