-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(map_loader): address deprecated warning for some environment #3188
fix(map_loader): address deprecated warning for some environment #3188
Conversation
Signed-off-by: kminoda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3188 +/- ##
=======================================
Coverage 12.27% 12.27%
=======================================
Files 1358 1358
Lines 94666 94666
Branches 26858 26858
=======================================
Hits 11616 11616
Misses 70804 70804
Partials 12246 12246
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…owarefoundation#3188) fix(map_loader): address deprecated warning for some version Signed-off-by: kminoda <[email protected]>
…owarefoundation#3188) fix(map_loader): address deprecated warning for some version Signed-off-by: kminoda <[email protected]>
…owarefoundation#3188) fix(map_loader): address deprecated warning for some version Signed-off-by: kminoda <[email protected]>
…owarefoundation#3188) fix(map_loader): address deprecated warning for some version Signed-off-by: kminoda <[email protected]>
Description
Some people got the following error. Although not everyone encounters this error, I would like to address this by small modification.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.