fix(motion_utils): change lane_id resampling method #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <[email protected]>
github-actions
bot
added
the
component:common
takayuki5168
requested review from
rej55,
kosuke55,
satoshi-ota,
taikitanaka3,
TakaHoribe,
tkimura4,
purewater0901 and
a team
as code owners
Signed-off-by: Takayuki Murooka <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3195 +/- ##
==========================================
+ Coverage 12.25% 12.27% +0.01%
==========================================
Files 1358 1358
Lines 94724 94777 +53
Branches 26887 26933 +46
==========================================
+ Hits 11613 11637 +24
- Misses 70853 70871 +18
- Partials 12258 12269 +11
*This pull request uses carry forward flags. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Apr 7, 2023
…on#3195) * fix(motion_utils): change lane_id resampling method Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
keita1523
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 8, 2023
…on#3195) * fix(motion_utils): change lane_id resampling method Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
keita1523
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 13, 2023
…on#3195) * fix(motion_utils): change lane_id resampling method Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed lane_ids resampling method so that the joint of different lane_ids (= the point which has multiple lane_ids) does not change.
Test performed
Planning simulator works well with this PR.
I confirmed that lane_ids in the path is correct with rviz visualization.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.