-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(motion_utils): change lane_id resampling method #3195
fix(motion_utils): change lane_id resampling method #3195
Conversation
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3195 +/- ##
==========================================
+ Coverage 12.25% 12.27% +0.01%
==========================================
Files 1358 1358
Lines 94724 94777 +53
Branches 26887 26933 +46
==========================================
+ Hits 11613 11637 +24
- Misses 70853 70871 +18
- Partials 12258 12269 +11
*This pull request uses carry forward flags. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…on#3195) * fix(motion_utils): change lane_id resampling method Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
…on#3195) * fix(motion_utils): change lane_id resampling method Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
…on#3195) * fix(motion_utils): change lane_id resampling method Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
Description
Fixed lane_ids resampling method so that the joint of different lane_ids (= the point which has multiple lane_ids) does not change.
Test performed
Planning simulator works well with this PR.
I confirmed that lane_ids in the path is correct with rviz visualization.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.