Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add new lateral acc condition #3304

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Apr 6, 2023

Description

Add new lateral acceleration when the lane-changing velocity is lower than a certain threshold.

🤖 Generated by Copilot at bf43e91

This pull request adds new parameters and logic to the lane change planner to adjust the lateral acceleration based on the vehicle speed. This can improve the comfort and safety of the lane change maneuver. The changes affect the lane_change.param.yaml configuration file, the LaneChangeParameters struct, the getLaneChangeParam function, and the calcLaneChangingDistance function.

Before the PR
image

After the PR:
image

Related links

autowarefoundation/autoware_launch#283

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (4db2047) 12.40% compared to head (6d1ac51) 12.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3304      +/-   ##
==========================================
- Coverage   12.40%   12.40%   -0.01%     
==========================================
  Files        1368     1368              
  Lines       96124    96130       +6     
  Branches    27697    27702       +5     
==========================================
  Hits        11928    11928              
- Misses      71528    71534       +6     
  Partials    12668    12668              
Flag Coverage Δ *Carryforward flag
differential 5.26% <0.00%> (?)
total 12.40% <ø> (+<0.01%) ⬆️ Carriedforward from 4db2047

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...anner/util/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.11% <0.00%> (-0.01%) ⬇️
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit 8e5bf82 into main Apr 10, 2023
@purewater0901 purewater0901 deleted the feat/enable-variable-acc branch April 10, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants