Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lidar_apollo_instance_segmentation, tensorrt_common): use onnx instead of caffe for apollo cnnseg #3320

Merged
merged 10 commits into from
Apr 12, 2023

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Apr 8, 2023

Description

🤖 Generated by Copilot at 3b4cb35

This pull request updates the lidar_apollo_instance_segmentation package and its dependencies to use the new TensorRT and CUDA libraries for faster and more robust lidar-based instance segmentation. It also improves the code quality, style, and consistency of the package by adding namespaces, include guards, license headers, and fixing typos and braces. It also simplifies the launch file and the .gitignore file by using the .onnx format for the neural network models.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@wep21 wep21 requested review from yukkysaito, a team and manato as code owners April 8, 2023 15:23
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Apr 8, 2023
@wep21 wep21 changed the title feat: use onnx instead of caffe for apollo cnnseg feat(lidar_apollo_instance_segmentation, tensorrt_common): use onnx instead of caffe for apollo cnnseg Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (1ca02e1) 12.40% compared to head (3966df6) 12.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3320      +/-   ##
==========================================
- Coverage   12.40%   12.40%   -0.01%     
==========================================
  Files        1368     1368              
  Lines       96191    96189       -2     
  Branches    27724    27724              
==========================================
- Hits        11931    11930       -1     
+ Misses      71594    71592       -2     
- Partials    12666    12667       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 12.40% <ø> (+<0.01%) ⬆️ Carriedforward from 98d8fe3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/lidar_apollo_instance_segmentation/cluster2d.hpp 0.00% <ø> (ø)
...de/lidar_apollo_instance_segmentation/debugger.hpp 0.00% <ø> (ø)
...de/lidar_apollo_instance_segmentation/detector.hpp 0.00% <ø> (ø)
...idar_apollo_instance_segmentation/disjoint_set.hpp 0.00% <ø> (ø)
...apollo_instance_segmentation/feature_generator.hpp 0.00% <ø> (ø)
...lidar_apollo_instance_segmentation/feature_map.hpp 0.00% <ø> (ø)
...nclude/lidar_apollo_instance_segmentation/node.hpp 0.00% <ø> (ø)
...nclude/lidar_apollo_instance_segmentation/util.hpp 0.00% <ø> (ø)
...dar_apollo_instance_segmentation/src/cluster2d.cpp 0.00% <0.00%> (ø)
...idar_apollo_instance_segmentation/src/debugger.cpp 0.00% <ø> (ø)
... and 5 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wep21
Copy link
Contributor Author

wep21 commented Apr 9, 2023

@yukkysaito
Copy link
Contributor

yukkysaito commented Apr 10, 2023

Thank you for PR 👍

@yukkysaito
Copy link
Contributor

yukkysaito commented Apr 10, 2023

@miursh @yukke42 Pls check this PR by TIER IV perception team 👍

@wep21 wep21 requested a review from yukkysaito April 10, 2023 08:17
@wep21 wep21 requested a review from kenji-miyake April 10, 2023 09:09
@wep21 wep21 requested a review from manato April 11, 2023 12:20
@manato
Copy link
Contributor

manato commented Apr 11, 2023

@wep21
Thank you for PR. Regarding common/tensorrt_common, it looks good to me. Also, I confirmed that this PR's modification does not have negative effect for building/executing tensorrt_yolox

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few questions

common/tensorrt_common/package.xml Show resolved Hide resolved
common/tensorrt_common/package.xml Show resolved Hide resolved
@miursh
Copy link
Contributor

miursh commented Apr 11, 2023

It looks like apollo cnn is working well.
image

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 enabled auto-merge (squash) April 12, 2023 05:38
@wep21
Copy link
Contributor Author

wep21 commented Apr 12, 2023

@yukkysaito You're the code owner of lidar_apollo_instance_segmentation, so I appreciate it if you could approve this PR.

@wep21 wep21 merged commit 03ae154 into main Apr 12, 2023
@wep21 wep21 deleted the feature/onnx-bcnn branch April 12, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants