fix(mpc_lateral_controller): use contant instead of macros

[kaancolak]

Description

I added transformPointCloud function to "tier4_perception_launch" package due to prevent runtime errors when comes to point cloud with zero points(relevant issue 3034) but there is some conflict between PCL's macros and mpc_lateral_control package's macros. I changed macros to "constexpr" variable inside to "tier4_autoware_utils".

I couldn't find an alternative way to turn around this if you have any comments please share them with me.

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[takayuki5168]

@kaancolak There is deg2rad/rad2deg functions in unit_conversion.hpp of the tier4_autoware_utils package.
Could you use it please.

[kaancolak]

@kaancolak There is deg2rad/rad2deg functions in unit_conversion.hpp of the tier4_autoware_utils package. Could you use it please.

Thanks @takayuki5168 Takayuki-san, for your advice, used unit_conversion functions instead of the new const variable.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.83 ⚠️

Comparison is base (3aead0d) 13.14% compared to head (4cc9d34) 12.32%.

❗ Current head 4cc9d34 differs from pull request most recent head 6c74311. Consider uploading reports for the commit 6c74311 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3358      +/-   ##
==========================================
- Coverage   13.14%   12.32%   -0.83%     
==========================================
  Files        1280     1380     +100     
  Lines       90688    96718    +6030     
  Branches    27925    27973      +48     
==========================================
- Hits        11919    11916       -3     
- Misses      66140    72171    +6031     
- Partials    12629    12631       +2     

Flag	Coverage Δ		*Carryforward flag
differential	46.72% <100.00%> (?)
total	12.31% <ø> (-0.83%)	⬇️	Carriedforward from 2ab576f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
control/mpc_lateral_controller/src/mpc.cpp	48.44% <100.00%> (ø)

... and 111 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.