-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mpc_lateral_controller): use contant instead of macros #3358
fix(mpc_lateral_controller): use contant instead of macros #3358
Conversation
Signed-off-by: Kaan Colak <[email protected]>
@kaancolak There is deg2rad/rad2deg functions in unit_conversion.hpp of the tier4_autoware_utils package. |
Signed-off-by: Kaan Çolak <[email protected]>
Thanks @takayuki5168 Takayuki-san, for your advice, used unit_conversion functions instead of the new const variable. |
Signed-off-by: Kaan Çolak <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3358 +/- ##
==========================================
- Coverage 13.14% 12.32% -0.83%
==========================================
Files 1280 1380 +100
Lines 90688 96718 +6030
Branches 27925 27973 +48
==========================================
- Hits 11919 11916 -3
- Misses 66140 72171 +6031
- Partials 12629 12631 +2
*This pull request uses carry forward flags. Click here to find out more.
... and 111 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Description
I added transformPointCloud function to "tier4_perception_launch" package due to prevent runtime errors when comes to point cloud with zero points(relevant issue 3034) but there is some conflict between PCL's macros and mpc_lateral_control package's macros. I changed macros to "constexpr" variable inside to "tier4_autoware_utils".
I couldn't find an alternative way to turn around this if you have any comments please share them with me.
Tests performed
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.